Added double newline after file upload markdown insert
All threads resolved!
All threads resolved!
What does this MR do?
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #28511 (closed)
Merge request reports
Activity
added 1 commit
- 5fa93471 - Added double newline after file upload markdown insert
UX: @dimitrieh FE+test: @alfredo1
@lbennett i tested it out, but there maybe something wrong with my gdk: https://gitlab.slack.com/archives/questions/p1487763917008796
and when uploading multiple files i still get this result:
assigned to @lbennett
added 1 commit
- 9f322f2b - Added double newline after file upload markdown insert
- Resolved by username-removed-408881
@lbennett LGTM
I wish we didn't have to usesleep
but I see we are using that previously. Hopefully we can find a way to get rid of those sleep later.@alfredo1 Yah, I figured it's because the dropzone.js library uses vanilla XMLHttpRequest for ajax. Looks like we do need to monkeypatch it in the test environment then.
Edited by Luke "Jared" Bennett
Please register or sign in to reply