Skip to content
Snippets Groups Projects

Added double newline after file upload markdown insert

Merged Luke "Jared" Bennett requested to merge newline-after-file-attachment-notes into master
All threads resolved!

What does this MR do?

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

2017-02-21_22.48.43

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #28511 (closed)

Merge request reports

Pipeline #6633054 passed

Pipeline passed for 9f322f2b on newline-after-file-attachment-notes

Test coverage 93.36% (-0.15%) from 1 job

Merged by username-removed-408881username-removed-408881 8 years ago (Feb 22, 2017 7:47pm UTC)

Loading

Pipeline #6634673 failed

Pipeline failed for fb81291e on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @lbennett LGTM :ok_hand: I wish we didn't have to use sleep but I see we are using that previously. Hopefully we can find a way to get rid of those sleep later.

  • username-removed-408881 resolved all discussions

    resolved all discussions

  • @alfredo1 Yah, I figured it's because the dropzone.js library uses vanilla XMLHttpRequest for ajax. Looks like we do need to monkeypatch it in the test environment then.

    Opened https://gitlab.com/gitlab-org/gitlab-ce/issues/28612

    Edited by Luke "Jared" Bennett
  • Please register or sign in to reply
    Loading