Skip to content

Bump Hashie to 3.5.5 and omniauth to 1.4.2 to eliminate warning noise

Stan Hu requested to merge sh-bump-hashie-to-3.5.5 into master

GitLab 8.17.0 appears to generate a lot of warning noise:

W, [2017-02-23T06:45:18.748540 #14051]  WARN -- : You are setting a key that conflicts with a built-in method OmniAuth::AuthHash::InfoHash#name defined at /usr/local/rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/omniauth-1.3.2/lib/omniauth/auth_hash.rb:34. This can cause unexpected behavior when accessing the key via as a property. You can still access the key via the #[] method.
W, [2017-02-23T06:45:25.212530 #14051]  WARN -- : You are setting a key that conflicts with a built-in method OmniAuth::Strategy::Options#method defined in Kernel. This can cause unexpected behavior when accessing the key via as a property. You can still access the key via the #[] method.

https://github.com/omniauth/omniauth/issues/872 appears to explain the reason why, and https://github.com/intridea/hashie/pull/406 should solve this problem.

Closes #28595 (closed)

Merge request reports