Resolve "missing count badge styling in new sidebar dropdown"
| Before | After |
|---|---|
 |
 |
Closes #28410 (closed)
Merge request reports
Activity
cc @cperessini
-
@cperessini @dimitrieh are all dropdowns supposed to be converted to this new style? Including Pipeline dropdowns?
@annabeldunstone I want to make this change, but I this is a pretty big style change so I feel we need some sort of consensus from all UX people.
Yes we should be consistent with the styling of our drop downs. @cperessini I would propose you review the dropdowns to ensure the new style fits with all elements within our dropdowns and provide mockups of ones like the pipeline dropdown and others that may require tweaks to colors like the badges.
added blocked label
@cperessini Personally I like it. However, it's challenging to make it work with dropdowns that have color (e.g. pipelines, labels). So this doesn't get blocked for too long, maybe it's a good idea to focus this MR on adding a badge styling to counters in dropdowns?
-
@pedroms the original issue with the badge styling in this dropdown was that it looks sort of ugly with the light blue. What will the short-term solution be for this? https://gitlab.com/gitlab-org/gitlab-ce/issues/28410#note_24068635
-
In this MR, lets just change the dropdown to the new style and then @cperessini can open up a new issue about reviewing dropdowns and making sure they are consistent. That way, all the problems can be worked out without blocking this MR.
-
How about this for a hover state for the badge?
I created #28921 (moved) for making dropdowns consistent
@cperessini that looks good and consistent
removed ~19492 blocked labels
mentioned in merge request !12528 (merged)
