Skip to content
Snippets Groups Projects

Prevent concurrent editing wiki

All threads resolved!

What does this MR do?

Prevent concurrent editing wiki.

I have referenced the change of !5122 (merged).

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

prevent_concourrent_editing_wiki

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #1827 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @hiroponz Great contribution! I left some comments.

  • added 1 commit

    Compare with previous version

  • @adamniedzielski I am done and waiting for your reply.

  • added 9155 commits

    • 839018d2...b92d5135 - 9152 commits from branch gitlab-org:master
    • 9b25bbc4 - Merge branch 'master' into 1827-prevent-concurrent-editing-wiki
    • 7ff9008f - Change double quotes to single quotes
    • df65334e - Refactor: use keyword arguments for optional parameters

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • @adamniedzielski Sorry for the late response, I have updated MR.

  • mentioned in merge request !10069 (merged)

  • @rymai We'll probably need another reviewer to pick this one up

  • @rspeicher Could you please review this one and !10069 (merged) since they're both about Wikis?

  • Robert Speicher
  • Robert Speicher
  • @hiroponz Sorry for the delay on this one! I've left a couple more notes. :thumbsup:

  • added 3 commits

    Compare with previous version

  • added 1 commit

    • 35259a4f - Encapsulate the commit.sha logic

    Compare with previous version

  • @rspeicher I have pushed new commits. Could you please review again?

  • Robert Speicher resolved all discussions

    resolved all discussions

  • Robert Speicher changed milestone to %9.5

    changed milestone to %9.5

  • Robert Speicher approved this merge request

    approved this merge request

  • Robert Speicher mentioned in commit 64131f04

    mentioned in commit 64131f04

  • My pleasure :smile:

  • Please register or sign in to reply
    Loading