group links select2 infinite scroll

What does this MR do?

adds infinite scrolling to the group links dropdown

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

• Changelog entry added
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

Closes #20013 (closed)

mentioned in issue #20013 (closed)

added 1 commit

• 9d09c1d1 - Update select2 to include 3.5.x infinite scrolling

Compare with previous version

added 1 commit

• 31a573a8 - Update select2 to include 3.5.x infinite scrolling

Compare with previous version

@iamphill could you review Frontend?

@rspeicher could you review specs?

assigned to @iamphill

added 1 commit

• 9bebfeca - Update select2 to include 3.5.x infinite scrolling

Compare with previous version

LGTM 👍 Tested it out & works fine. Doesn't look exactly like the designs with 'Showing x of x' but I understand the limitations.

assigned to @lbennett

@iamphill Thanks for a timely review, on it right now. Yeah, I decided to ignore meeting the exact design specs in favour of speed, but behaves as it needs to. Will be opening a technical debt issue where I will include this.

resolved all discussions

added 1 commit

• d59f32ad - Update select2 to include 3.5.x infinite scrolling

Compare with previous version

Round 2. 🤗

/cc @rspeicher /cc @iamphill

assigned to @iamphill

added 1 commit

• 9d0532dd - Update select2 to include 3.5.x infinite scrolling

Compare with previous version

eslint error https://gitlab.com/gitlab-org/gitlab-ce/builds/11864778

@rspeicher you happy with tests?

Approved this merge request

assigned to @rspeicher

@iamphill Thanks for catching that, my pre-commit hook is broke 😢 Pushed a fix :)

added 1 commit

• 90c1ebcb - Update select2 to include 3.5.x infinite scrolling

Compare with previous version

All builds green :) ✅

@lbennett One spec fix.

assigned to @lbennett

Thanks @rspeicher ❤️

resolved all discussions

added 280 commits

• 90c1ebcb...5e05d6b8 - 279 commits from branch master
• 5341576d - Update select2 to include 3.5.x infinite scrolling

Compare with previous version

@rspeicher Made those changes, can you MWPS?

assigned to @rspeicher

@lbennett Another question.

assigned to @lbennett

resolved all discussions

added 77 commits

• 5341576d...9226ce9e - 76 commits from branch master
• be06e01f - Update select2 to include 3.5.x infinite scrolling

Compare with previous version

assigned to @rspeicher

Approved this merge request

Pushing to %9.1 since we're post-feature-freeze.

changed milestone to %9.1

assigned to @fatihacet

@jschatz1 can you review this please?

assigned to @jschatz1

resolved all discussions

added 759 commits

• be06e01f...15ca592f - 758 commits from branch master
• a1b1387d - Merge branch 'master' into 'group-links-select2-infinite-scroll'

Compare with previous version

added 759 commits

• be06e01f...15ca592f - 758 commits from branch master
• a1b1387d - Merge branch 'master' into 'group-links-select2-infinite-scroll'

Compare with previous version

approved this merge request

resolved all discussions

added 1 commit

• f1016022 - add space to force CI.

Compare with previous version

approved this merge request

@lbennett tested and works great. Only problem is the spinner for the infinite scrolling is off the dropdown to the right.

Should at least be in the bounds of the dropdown. Better would be to have a little padding on the right.

assigned to @lbennett

Actually @lbennett I am going to merge. Can you fix in another MR? Make a new issue for that.

enabled an automatic merge when the pipeline for f1016022 succeeds

@lbennett There seem to be legit failures! ;)

canceled the automatic merge

resolved all discussions

@rymai No idea how that's happened, that's a bit suspect.

Utohh, looks like we sunk a commit and lost some changes. I'll restore it :)

added 25 commits

• f1016022...839183f2 - 22 commits from branch master
• 9e9d8589 - Fix tests
• 2b3d3900 - Merge branch 'master' into group-links-select2-infinite-scroll
• ce9f4ce0 - Fix missed commits

Compare with previous version

Fixed.

assigned to @rymai

approved this merge request

enabled an automatic merge when the pipeline for ce9f4ce0 succeeds

Great now some unrelated errors that pass locally. 😓

added 51 commits

• ce9f4ce0...412c9e8b - 47 commits from branch master
• 2ee5719c - Update select2 to include 3.5.x infinite scrolling
• e852bb7f - add space to force CI.
• 172644ac - Fix tests
• 844b3347 - Fix missed commits

Compare with previous version

The broken job is the same as #30236 (closed), hopefully resolved by !10315 (merged).

@rymai !10315 (merged) got merged so I updated, rebased and pushed. :)

added 34 commits

• 844b3347...4cf16426 - 30 commits from branch master
• d5268da0 - Update select2 to include 3.5.x infinite scrolling
• 52cbd8e7 - add space to force CI.
• 887d02c3 - Fix tests
• 6a5cbac0 - Fix missed commits

Compare with previous version

approved this merge request

merged

mentioned in commit bee8b242

mentioned in issue #30591 (closed)