Skip to content

WIP: Fix side-by-side diff comments UI glitches

Stan Hu requested to merge stanhu/gitlab-ce:fix-side-by-side-ui-glitches into master

There are a number of UI glitches when trying to comment on side-by-side diffs, especially if you attempt to comment on the same line in the "old" and "new" panes or delete comments from the list. It seems every time I fix one thing I seem to break another.

Current bugs in this branch:

  • Deleting all notes from one side removes the others in side-by-side mode
  • Adding a note to the right side when left ones exists does not show up
  • Removing notes doesn’t always clear the surrounding pane in side-by-side mode
  • Comment counts don't always increment in normal diff view
  • After adding a new note to an existing one, the autosave text is not cleared

Merge request reports