Remove trailing `.` from user names created by FactoryGirl (!9940) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

username-removed-128633 requested to merge 25837-fix-transient-failure into master Mar 14, 2017

What does this MR do?

This remove any trailing . in user names created by FactoryGirl.

Are there points in the code the reviewer needs to double check?

Hopefully, no specs should fail because of that.

Why was this MR needed?

Because, some Git-related expectation would fail when the name ends with a ., e.g. Waylon Dickinson Sr. as you can see in https://gitlab.com/gitlab-org/gitlab-ce/builds/7639690. In the particular case of https://gitlab.com/gitlab-org/gitlab-ce/builds/7639690, the spec failure was even harder to debug because of json_response which was implemented as a memoized instance variable instead of a let variable (this has been fixed by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9825).

Closes #25837 (closed)