ESLint: Fix `promise/catch-or-return` offences
All threads resolved!
All threads resolved!
What does this MR do?
This MR is an extension of !9969 (merged) and fixes promise/catch-or-return offences.
Are there points in the code the reviewer needs to double check?
Review every catch block added carefully to see if implementation is correct for the context or not.
Why was this MR needed?
See #27486 (moved)
Does this MR meet the acceptance criteria?
[ ] Changelog entry added[ ] Documentation created/updated[ ] API support added- Tests
[ ] Added for this feature/bug-
All builds are passing
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #29626 (moved)
Merge request reports
Activity
marked the task Conform by the merge request performance guides as completed
marked the task Conform by the style guides as completed
marked the task Squashed related commits together as completed
-
Thank you for this @kushalpandya!
mentioned in merge request !9969 (merged)
@kushalpandya maybe just create a technical debt issue to address them.
mentioned in issue #29626 (moved)
-
@iamphill created meta issue #29626 (moved), and also referenced to all occurrences there which are being fixed in this MR.
-
@kushalpandya do you need help with this one?
'alert'parameter is not needed innew Flash()it's the default one :) -
@filipa I'll update all usages.
added 374 commits
-
8207badd...4bf4612c - 111 commits from branch
27486-eslint-promises - 7a399b70 - Strip reference prefixes on branch creation
- 1bc5dab7 - Add real_ip setting to nginx example.
- 330d4f38 - dismissable error close is not visible enough
- 79c3ace8 - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9623#note_24573655
- 49c920fb - Issue boards blank state template in JS file
- c0a4f527 - Use Gitaly for CommitController#show
- 3619ce04 - Resolve GitLab QA cold boot problems on entry page
- 0de8dccd - Fix bug when system hook for deploy key
- 8135ea99 - Catches errors when generating lists
- de93054e - Fixed eslint
- adeafa40 - Fixes diff comment avatar tooltip escaping issues
- 3f111741 - Use "branch_name" instead "branch" on V3 branch creation API
- 790d9d40 - Fix Unicode 1.1 emojis
- 03ebbccf - Restore sub-nav for empty project
- 992e0680 - Clarify help text
- f451f777 - Make the test less time sensitive by extending 0.2
- 46287f36 - Make sure alias email would never match:
- cc887599 - Do not use Ruby Timeout module in GitLab QA
- 03f6f51d - Reset issue boards add issues modal page when filtering
- f016da62 - Merge branch 'fix-make-time-test-more-reliable' into 'master'
- a4069187 - Refactor award emojis document
- d6c4453a - Stop CI notification showing when status is nil
- 517598ba - Add a new have_html_escaped_body_text that match an HTML-escaped text
- 2f145352 - Merge branch 'fix-make-email-static' into 'master'
- 8d8dfd8e - documentation blurb in issue template
- 5ae6d1f8 - Add a documentation blurb to the new issue template to encourage writing (better) documentation.
- d68c23a0 - Merge branch '26470-branch-names-with-reference-prefixes-results-in-buggy-branches' into 'master'
- f2be76f3 - Added labels to the issue web hook
- 68e3fa0e - Add ability to disable Merge Request URL on push
- 375b870b - Merge branch '21451-allow-disable-mr-link' into 'master'
- d5003424 - Merge branch '29604-v3-fix-branch-creation' into 'master'
- 1ac6bb55 - Merge branch 'add-labels-to-issue-hook' into 'master'
- 357db226 - Merge branch '29577-restore-sub-nav-with-activity-tab' into 'master'
- b29a8e3c - Merge branch 'boards-blank-state-template-in-js' into 'master'
-
c77fc4ce - Add global
g tshortcut to go to todos - 4c2ea7d0 - Merge branch 'docs/award_emojis' into 'master'
- 2e1b9999 - Updates realtime documentation for the Frontend
- 7add0e85 - Merge branch 'update-realtime-docs' into 'master'
- 2b2ce1b2 - Merge branch 'build-notification-null-check' into 'master'
- 76f7cf92 - Fix time-sensitive helper spec
- 7a623907 - Merge branch '20121-add-a-new-have_html_escaped_body_text-matcher' into 'master'
- cc25c4c0 - Allow creating merge request even if target branch is not specified in query params
- faa4b535 - Fixed filter bar alignment issues
- 9a20ff1c - Added Gitlab::Database.config
- 06c44109 - Fixed mobile alignment issues
- a2f2b951 - Remove width from nav links
- 1a4aa8d7 - Merge branch '29557-fix-unicode-1-1' into 'master'
- bb1620aa - Merge branch 'fix-time-sensitive-helper-spec' into 'master'
- b0f2cbce - Remove UJS actions from pipelines tables
- 0e4f2e01 - Merge branch 'fl-remove-ujs-pipelines' into 'master'
- c1b4f800 - Merge branch 'fix/gb/gitlab-qa-start-page-cold-boot' into 'master'
- 5409a3c5 - Merge branch 'feature/use-gitaly-for-commit-show' into 'master'
- bbddd770 - Merge branch 'database-config-method' into 'master'
- 90ade76b - Resolve "Extract logic of who should receive notification into separate classes"
- d90c2505 - Merge branch '27477-refactor-notification-recipients' into 'master'
- e6f4a4c1 - Merge branch 'fixed-diff-avatar-tooltip-escaping' into 'master'
- 94c19fbf - Add closed_at field to issues
- 5d71d9fb - Merge branch '29586-pipelines-tabs' into 'master'
- 4ecb0380 - 26236 Change gfm textarea to use monospace font
- f8ceee24 - Rename 'All issues' to 'Open issues' in Add issues modal
- 94246c7a - Merge branch '26236-monospace-gfm' into 'master'
- 12dd5ac2 - All CI offline migrations
- 0eff4f14 - Merge branch 'all-ci-offline-migrations' into 'master'
- 35de410d - Append _spec to group_name_toggle spec file
- 67eefe7e - don't show loading spinners for server-rendered sidebar fields
- 19677dd4 - Add filter focus for filtered search visual tokens
- 666c20cb - Remove repeated routes.path check for postgresql database
- 652d8045 - Fixed pagination in projects & snippets on user page
- 92b5e396 - Update 8.12-to-8.13.md: gitlab version 8.13 wants gitlab-shell v3.6.7
- 307d706c - Add additional details on metric source being k8s nodes
- 681af5bc - Fix Error 500 when application settings are saved
- 4ccf874d - Update CHANGELOG.md for 8.15.8
- b730fb45 - Update CHANGELOG.md for 8.16.8
- 770a703b - Update CHANGELOG.md for 8.17.4
- 3a43b55a - Merge branch '24683-sidebar-spinners' into 'master'
- 8f67a260 - Merge branch 'rename_all_issues' into 'master'
- 691402fb - Merge branch '3kami3/gitlab-ce-real_ip'
- aaaee8ae - Allow unauthenticated access to some Branch API GET endpoints
- bbf4d27a - Make runner's veryfication working again
- e79ab111 - Remove legacy Runners support in /api/v4/jobs/request
- 9267a9b1 - Send token of depenent job
- c191c110 - Send only defined dependencies
- 45f1975d - Simplify Ci::Build#dependencies method
- 37b36b46 - Update example's name in /runners/verify tests
- 6006aaf5 - Use google-protobuf 3.2.0.2
- 359caf2b - Merge branch '29662-allow-unauthenticated-branches-api' into 'master'
- ef86353e - Fixed source branch name not being in new merge request dropdown toggle
- 9bfff603 - Merge branch '28890-allow-creating-mr-without-target-branch-in-url' into 'master'
- bf41a2e7 - Todos performance: Include associations in Finder
- 67603d04 - Simplify trigger_docs build job for CE and EE (!9820 (merged))
- acbb8c0f - Fail trigger_docs if triggering build was not successful
- de518e12 - Allow dot in branch name in trigger/builds endpoint in API
- a040e3ba - Merge branch '29438-fix-trigger-webhook-for-ref-with-dot' into 'master'
- d454e100 - Merge branch 'fix/regressions-in-ci-v4-api' into 'master'
- 37328406 - Merge branch '29534-todos-performance' into 'master'
- 62194ab4 - Merge branch 'patch-10' into 'master'
- 915af2dc - Merge branch 'protobuf-3.2.0.2' into 'master'
- 6181b354 - fixes large text tooltip in diff file name
- 04f62ac2 - Remove useless options from db/fixtures/development/17_cycle_analytics.rb
- d29f90b5 - Update deploy keys documentation
- 2dd9b8a3 - Fix Project Wiki update
- b075d38c - Merge branch '29405-fix-project-wiki-update' into 'master'
- aea78ded - Redirect to signin when New Issue for not logged in
- 51f07069 - handle commas in Issue total count
- cd3e4101 - Merge branch 'routes-lower-case' into 'master'
- 24a33118 - Update docs to indicate prometheus k8s monitoring is on by default
- fa87ff0e - Minor tweak
- be25bbc4 - Fix ProjectWiki#http_url_to_repo signature
- 2413a4b5 - Remove unnecessary paragraph
- df0778a4 - Merge branch 'issue_27212' into 'master'
- a1a04828 - Merge branch 'deploy-keys-docs' into 'master'
- 970541e0 - Fix input token spacing
- a13b8434 - Make the v3_to_v4.md more consistent
- 6c6de7f1 - Add additional check for when inputContainer does not exist
- ca0d8438 - Improve rename projects migration
- 81e6cbc9 - Merge branch '29713-update-documentation-to-reflect-prometheus-monitors-k8s-by-d…
- 8ab347b3 - Return 404 in project issues API endpoint when project cannot be found
- 2de768e2 - add an index to the ghost column
- f441b95b - Fix pipeline status for transition between stages
- 3729490e - Update css to be nice and tidy.
- 85759f2c - Merge branch '20204-new-issue-button-redirects-you-to-create-a-new-issue-after-l…
- 0b5e1392 - Extend compound status for manual actions specs
- 5bdab11f - Merge branch 'issue-filter-bar-alignment' into 'master'
- b9120c77 - Removed d3.js from the main application.js bundle
- d8138385 - Merge branch 'fix-prometheus-including-d3-main-bundle' into 'master'
- 0ebf97b0 - Merge branch 'fix-input-token-spacing' into 'master'
- fc2f0eba - Merge branch 'simplify-docs-trigger' into 'master'
- b26d4d2a - Merge branch '29491-rename-file-for-group-name-toggle' into 'master'
- dd3d62b6 - Make feature spec more robust
- 3fa82f9f - Add space to bottom of screen
- 71306f14 - Make level_value accept string integers
- 4e1cebab - Undo explicit conversion to Integer
- f64fbf0e - Added unit tests for the w.gl.utils.backOff promise
- 20cbfb48 - Removed unused response in promise
- 543f68b8 - fix recompile assets step in 9.0 upgrade guide to use yarn
- fde335bf - Only add frontend code coverage instrumentation when generating coverage report
- c087ce16 - Merge branch 'make-karma-fast-again' into 'master'
- 80f46fe0 - Merge branch '29559-issue-count' into 'master'
- 63c26980 - Merge branch '28660-fix-dismissable-error-close-not-visible-enough' into 'master'
- 87b9cee3 - Merge branch '28499-fix-large-text-tooltip-in-diff-file-name' into 'master'
- 9bf9e6eb - Handle Route#name being nil after an update
- f01ce091 - Reset filters after click
- 60853843 - Merge branch 'reset-filters-after-click' into 'master'
- 2de664b1 - Merge branch 'token-bug-fixes' into 'master'
- 204afc1b - Fix karma test
- 7601d8b0 - Merge branch 'clear-page-param-after-filter-in-add-issues-modal' into 'master'
- f5bc48cf - Merge branch '29730-9-0-upgrade-documentation-should-include-yarn' into 'master'
- 58f2db49 - Changed code style as to not to disable any eslint rules
- 153b594c - Merge branch '28058-hide-emails-in-atom-feeds' into 'security'
- c5a9d73a - Merge branch 'fix-links-target-blank' into 'security'
- 65aafb99 - Merge branch 'ssrf' into 'security'
- 956e3649 - Replace closing MR icon
- 83a0c398 - Merge branch 'ssrf' into 'security'
- 7be39a89 - Merge branch 'render-json-leak' into 'security'
- 4ea85da9 - Merge remote-tracking branch 'dev/master'
- 2cdfbbfc - Merge branch 'rs-issue-29592' into 'master'
- d9dedc36 - remove Vue from the global space
- 632497bd - make eslint happy
- 96c7bd03 - fix wait_for_vue_resource to not rely on global Vue object
- 0d885e48 - remove additional instances of window.Vue
- 26a98194 - Merge branch 'bugfix/systemhook' into 'master'
- 6a910479 - Merge branch '29671-remove-useless-options' into 'master'
- b9d4d535 - Merge branch 'fix-typos-in-v3-to-v4-doc' into 'master'
- 9b57b4bb - Merge branch 'perf/add-index-to-user-ghost' into 'master'
- 977f6e37 - Merge branch 'add-filter-focus-style' into 'master'
- 07415e47 - Fix Error 500 when Bitbucket importer does not have authorization
- 57a6edd1 - Move text to a MD heredoc.
- f592cae1 - Merge branch 'sh-fix-admin-application-settings' into 'master'
- e8942846 - Hide ancestor groups in the share group dropdown list
- 2f0a2e99 - Merge branch 'dz-improve-rename-projects-migration' into 'master'
- 4146be04 - Merge branch '29685-wrong-number-of-arguments-calling-http_url_to_repo-on-clonin…
- 69af06dd - Add LIKE index for routes.path
- 46146e33 - Merge branch 'fix/gb/pipeline-intermittent-running-status' into 'master'
- 7b04b63e - New directory from interface on existing branch
- 163ba974 - Fix CreateBranchService after Repository#commit_file was renamed to create_file
- 1e5888d1 - Merge branch 'api-project-issues-404' into 'master'
- 5b41b792 - Prevented error on nil author from Issuable delegation
- 20261052 - Clean cache after bundling
- 4ebc6239 - Merge branch 'create-branch-service-create-file' into 'master'
- ce488d3b - Fix invalid YAML in changelogs/unreleased/27142-api-replace-destroy-with-stop-environment.yml
- b356ce7e - Add a rake task to reset all email and private tokens
- 673618d3 - Merge branch 'feature/tokens-rake-task' into 'master'
- 7f411ea3 - Merge branch 'fix-invalid-yaml-in-changelog-entry' into 'master'
- b3d77dba - Merge branch 'index-routes-path-for-like' into 'master'
- 8548aaa0 - Merge branch '29618-clarify-help-text-on-prometheus-integration-page' into 'master'
- 0ebf1462 - Merge branch 'dz-hide-share-group-ancestors' into 'master'
- 3883a5f9 - Rake task that can install gitaly at a tag version
- 49a9c2fb - Print command output when a task failed
- 275b7797 - Add gitaly source installation instructions
- 6c3ce620 - Remove unnecessary before block
- d791b1ef - Add gitaly admin docs
- a08c707c - Merge branch '29428-new-directory-from-existing-branch' into 'master'
- 414ce037 - Fix typo [ci skip]
- 2d46a572 - Resolve "Circular dependency detected" (duplicate)
- 72b1af3a - Merge branch '28618-fix-circular-dependency' into 'master'
- b22d4c2e - Merge branch 'add-test-backoff-util' into 'master'
- db8f52d4 - Merge branch '29659-add-padding' into 'master'
- 1974691b - Revert "Merge branch '29534-todos-performance' into 'master'"
- 7afbb761 - Merge branch 'source-branch-toggle-text' into 'master'
- fc830c6f - Merge branch 'gitaly-install-rake' into 'master'
- fa7f409f - Merge branch 'sh-fix-issue-29739' into 'master'
- 3750766f - Escape route path for LIKE queries
- 222cfda9 - Resolve "Fix the Prometheus queries for multiple container environments"
- a12c6db8 - Merge branch '29302-improve-the-prometheus-queries-for-multiple-container-enviro…
- 0b71dbcc - Merge branch 'jej-backport-authorless-fix' into 'master'
- 5f729268 - Merge branch 'replace_closing_mr_icon' into 'master'
- 86ef67ee - Present ajax call errors when failing to update an Issue
- d730b69e - Spam check only when spammable attributes have changed
- 50d9204f - Merge branch '29583-routes-like-fix' into 'master'
- 45a2f900 - Merge branch 'revert-37328406' into 'master'
- 844142e9 - Fix routes index migration
- a3111e14 - Escape values passed from Rails to Vue to make sure the template can be compiled
- 6cc88580 - Merge branch 'fix-routes-index-migration' into 'master'
- 9ba5f10f - Merge branch 'dm-fix-vue-cant-compile-some-discussions' into 'master'
- 2cab5d07 - Update 8.13-to-8.14.md: Fixed gitlab-shell version
- d4c8e847 - Fix "N changed files" link toggler jumping to top
- 77eda528 - Merge branch 'resolve-global-vue' into 'master'
- b2c2cd28 - Removed unnecessary 'add' text in additional award emoji button
- 57f79da9 - Merge branch 'cleaner-additional-award-emoji-button' into 'master'
- d023e92f - upgrade Vue to v2.2.4
- 6a3980ef - disable the Vue production warning in development and testing
- d0db9666 - utilize ES module distribution for Vue in webpack
- 32935bc9 - add CHANGELOG.md entry for !9981 (merged)
- 22856474 - move common vue script to vue_shared directory
- a1b68aa4 - Merge branch '29043-upgrade-vue-and-remove-warnings' into 'master'
- 0cafbd79 - Merge branch 'zj-clean-gems' into 'master'
- d48b95e2 - Fixed the job tootip being cut-off
- bd90f502 - Update CHANGELOG.md for 9.0.0
- c94172ee - Move the 9.0.0 CHANGELOG entries to the top
- 74459e0c - Merge branch 'pipelines-build-tooltip' into 'master'
- 141ee129 - Merge branch 'fix-changelog-9-0' into 'master'
- 95197ee3 - Remove not necessary specs
- d618d010 - Add spec that tests ‘LIKE’ query for routes with _
- 78840333 - Merge branch 'add-todos-shortcut' into 'master'
- 85ffd85a - Merge branch '29483-spam-check-only-title-and-description' into 'master'
- 7f94bdda - Correct pipeline trigger GET functionality.
- 6194db8c - Merge branch '29775-route-changes' into 'master'
- cf3b0ca4 - Fix some random failures
- bfb28ecc - Move merge-request-info style to only apply to related MRs
- 71b52e75 - Merge branch 'patch-11' into 'master'
- c62314ab - Merge branch 'profile-project-pagination-json-fix' into 'master'
- c9c23535 - Update user's profile preferences docs
- d70f9c85 - Merge branch 'fix_some_random_failures' into 'master'
- 3574963b - Merge branch 'docs/profile-preferences' into 'master'
- 8c3bdc85 - Creates Frontend Style guide
- 2369050a - Merge branch '28713-fe-style-guide' into 'master'
- 0068c449 - Merge branch 'patch-15' into 'master'
- ad61ba45 - Corrected the color from the time tracking icon in the issuable sidebar
- 1af9dfb8 - Merge branch 'time-tracking-color-not-consistent' into 'master'
- 011664fd - Merge branch '29414-fix-link-toggler-diff-changed-files' into 'master'
-
ad369a96 - Fix
Ctrl+Entersupport for Quick Submit - f83d79d0 - Merge branch '29550-fix-quick-submit-on-preview' into 'master'
- bcbd0325 - Merge branch 'mr-list-alignment' into 'master'
-
735ab933 - Add
aria-labelfor feature status accessibility - 3918c303 - Merge branch '27503-feature-status-aria-labels' into 'master'
-
45cd837a - Add
eslint-plugin-promiseto lint Promises - d2d35951 - Enable eslint-plugin-promise
- 39cbf957 - Fix dependency tree using latest Yarn
-
2a5b374f - ESLint: Fix
promise/catch-or-returnoffences -
7c2db155 - Show
Flashmessage on failing to load boards - 8885e753 - Log error on failing to load Emoji categories
-
2b23b788 - Remove unnecessary type parameter for
Flash -
de5c1c3f - ESLint: disable
promise/catch-or-returnfor tests
Toggle commit list-
8207badd...4bf4612c - 111 commits from branch
added 8 commits
-
de5c1c3f...240aefc2 - 3 commits from branch
27486-eslint-promises -
f5eb7e80 - ESLint: Fix
promise/catch-or-returnoffences -
2077cfea - Show
Flashmessage on failing to load boards - 02f1e002 - Log error on failing to load Emoji categories
-
9d7bd5dc - Remove unnecessary type parameter for
Flash -
a9910ffa - ESLint: disable
promise/catch-or-returnfor tests
Toggle commit list-
de5c1c3f...240aefc2 - 3 commits from branch
-
@filipa what to do for 3 remaining empty
.catch()blocks? rspec continues to complain about it.
-
@iamphill can you please help, all of them are in boards
@kushalpandya can we not just leave them blank & fill them in another time? Why is rspec complaining about them?
-
@iamphill here's the log from failing rspec for
spec/features/boards/boards_spec.rb, I'm getting 7 failures all pointing to emptycatchblock, here's the failing pipeline Job 12816722.1) Issue Boards with lists removes checkmark in new list dropdown after deleting Failure/Error: click_button 'Add list'Capybara::Poltergeist::JavascriptError: One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details). TypeError: undefined is not a function (evaluating '$.get($this.attr('data-labels')).then(function (resp) { callback(resp); }).catch(function () { // An empty catch! })') TypeError: undefined is not a function (evaluating '$.get($this.attr('data-labels')).then(function (resp) { callback(resp); }).catch(function () { // An empty catch! })') at http://localhost:3808/assets/webpack/boards.bundle.js:1463 in data at http://localhost:3808/assets/webpack/main.bundle.js:38654 in execute at http://localhost:3808/assets/webpack/main.bundle.js:38951 in opened at http://localhost:3808/assets/webpack/main.bundle.js:38503 at http://localhost:3808/assets/webpack/common.bundle.js:10627 in dispatch at http://localhost:3808/assets/webpack/common.bundle.js:10439 in handle at http://localhost:3808/assets/webpack/common.bundle.js:13686 in trigger at http://localhost:3808/assets/webpack/common.bundle.js:13770 at http://localhost:3808/assets/webpack/common.bundle.js:6255 in each at http://localhost:3808/assets/webpack/common.bundle.js:6032 in each at http://localhost:3808/assets/webpack/common.bundle.js:13769 in trigger at http://localhost:3808/assets/webpack/common.bundle.js:561 in toggle at http://localhost:3808/assets/webpack/common.bundle.js:10627 in dispatch at http://localhost:3808/assets/webpack/common.bundle.js:10439 in handle at :0 in sendEvent at phantomjs://code/web_page.js:55 at phantomjs://code/web_page.js:501 in mouseEvent at phantomjs://code/node.js:67 in mouseEvent at phantomjs://code/browser.js:372 in mouse_event at phantomjs://code/browser.js:393 in click at phantomjs://code/browser.js:85 in runCommand at phantomjs://code/cmd.js:26 in run at phantomjs://code/main.js:22 in runCommand at phantomjs://code/connection.js:16 in commandReceived at phantomjs://code/connection.js:1Edited by kushalpandya @kushalpandya its a legit error. I think that one uses
jQuery.getwhich doesn't have.catchso its.failfor jQuery right?-
@iamphill my bad
app/assets/javascripts/boards/components/new_list_dropdown.js. Although I'm still getting 2 unrelated failures on above mentioned spec as follows;1) Issue Boards with lists lists issue moves between lists Failure/Error: let(:project) { create(:empty_project, :public) } ActiveRecord::RecordNotUnique: PG::UniqueViolation: ERROR: duplicate key value violates unique constraint "index_routes_on_source_type_and_source_id" DETAIL: Key (source_type, source_id)=(Namespace, 3) already exists. : INSERT INTO "routes" ("source_type", "path", "name", "source_id", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5, $6) RETURNING "id"and
2) Issue Boards with lists lists issue moves from closed Failure/Error: pos_before = before.relative_position NoMethodError: undefined method `relative_position' for nil:NilClass @kushalpandya a retry would usually solve them
added 364 commits
-
7f01fdf2...11289b6e - 357 commits from branch
27486-eslint-promises -
3709a08a - ESLint: Fix
promise/catch-or-returnoffences -
f731c468 - Show
Flashmessage on failing to load boards - e470cc4d - Log error on failing to load Emoji categories
-
d5533837 - Remove unnecessary type parameter for
Flash -
b8c9103a - ESLint: disable
promise/catch-or-returnfor tests -
fc93c1b3 - Throw
Errorinstead of logging in console -
d96d7889 - Add empty
.fail()and.catch()blocks
Toggle commit list-
7f01fdf2...11289b6e - 357 commits from branch
added 12 commits
-
d96d7889...132be173 - 5 commits from branch
27486-eslint-promises -
91b1c163 - ESLint: Fix
promise/catch-or-returnoffences -
dcc8d347 - Show
Flashmessage on failing to load boards - dd86a401 - Log error on failing to load Emoji categories
-
5a0fa6b2 - Remove unnecessary type parameter for
Flash -
6a2779ef - ESLint: disable
promise/catch-or-returnfor tests -
f3f3b8f5 - Throw
Errorinstead of logging in console -
b8a6369f - Add empty
.fail()and.catch()blocks
Toggle commit list-
d96d7889...132be173 - 5 commits from branch
added 1128 commits
- e43b2e81 - Added MR Road map
- dcd4beb8 - Multi-level container image names backend implementation
- eed0b85a - First iteration of container_image view
- 246df2bd - Adding registry endpoint authorization
- e4fa80f3 - Fixes broken and missing tests
- 164ef8a3 - Fixing typos in docs
- b408a192 - Adding mock for full_access_token
- ea17df5c - Fixing minor view issues
- 8294756f - Improved readability in tag/image delete condition
- db5b4b8b - Creates specs for destroy service and improves namespace container image query performance
- 98a69162 - Hide form inputs for user without access
- 3e4dee01 - Changelog entry for issue #24861 (closed)
- 1a36b181 - Remove author name
- 7cd1b510 - Remove unnecessary variable
- 1f7c6657 - Updated droplab version to webpack version
- a1f5eaf1 - add writing docs page
- 108a1e99 - update readme - add doc articles and indexes per topic
- c95125e1 - add intro to indexes per topic
- e4cd6c68 - add topics dir to doc_styleguide
- dda8896e - rename "documentation articles" to "technical articles"
- f6d06ad4 - rename remaining experession
- b3abbe13 - link to tech articles description
- 2edd3c0f - describes what a tech article is
- 60a09846 - add distinction between guide and tutorial
- fa079afb - add link
- c6a091d6 - grammar fix
- f94b6567 - add examples of guide vs tutorial
- c7b4b150 - add the "special format" to the only guide we already have in the docs
- b1f38684 - Improves Jira integration documentation
- 8a6becca - Merge branch 'master' into update-droplab-to-webpack-version
- 16cca3a0 - Expose if action is playable in JSON
- 3f9ab9bc - Protect tag partial
- 421a386d - Apply styles to protected tag same as protected branch
- d20c5427 - Render protected tags within Project Settings > Repository
- 53d332d3 - Add configured container registry key to .gitignore
- c5912ecd - Merge branch 'master' into feature/multi-level-container-registry-images
- c64d3630 - Makes ContainerImages Routable
- 97a02fca - Protected Tags Classes
- c5c4370a - Re-export protected tag classes
- 167b8600 - Initialize Protected tags feature under Repository Settings page
- 0fd2fd65 - Update property names for tags
- 99859b01 - Add protected tags to bundle config
- 68a2fa54 - Remove out-of-scope changes for multi-level images
- 29c34267 - Move container images migration to the present time
- 95e2c019 - Clean code related to accessing registry from project
- e0cc7bd7 - Update copy for first row in filtered search dropdown
- 67f9614c - Change copy for first row in filtered search
- 896b13b9 - Refactor splitting container image full path
- bbd54934 - add instructions on subtopics
- 93387599 - remove linked indexes (examples)
- e70ed3a1 - add pipeline symbols
- 7bfa5234 - Resolve future conflicts with CE -> EE merge
- 4005eb64 - Fix communication between GitLab and Container Registry
- bd8c8df6 - Fix database schema
- 01d159b4 - Rename container image model to container repository
- ea16ea5b - Identify container repository by a single name
- f451173a - Fix specs for container repository model class
- 9c9aac3d - Prevent Trigger action buttons from wrapping
- 249084b4 - Fix some specs using the old ContainerImage const
- 3e01fed5 - Fix Rubocop offenses in container repository code
- 5058fc67 - Remove redundant code to convert restricted_levels to integers
- dcd2eeb1 - Rename container image to repository in specs
- f31bf3d7 - don't pad hidden sidebar on build and wiki pages
- af42dd29 - Fix specs for container repository tags
- 7db1f226 - Fix specs for services related to container registry
- 4fdcaca6 - Fix container registry blob specs
- 16e645c6 - Remove container_registry method from project class
- d6f37a34 - Fix feature specs related to container registry
- dce706bf - Do not require a manifest for container repository
- 7ada193e - Fix specs for container repository destroy service
- 9acfa635 - adds todo functionality to closed issuable sidebar and changes todo bell icon to check-square
- 96f51880 - Updated todos sidebar icon
- 822bfafa - add basic sidebar functionality to milestones page
- 71e798f5 - prevent formatted milestone date string from having html escaped
- 92e0bd9b - add milestone reference clipboard button to sidebar
- 9023526c - move milestone due date info to sidebar
- 470bba5c - move issue and milestone counts to sidebar
- 2bacc040 - move links to browse issuables into sidebar
- 38c13673 - update styling for milestone sidebar content
- d3de86c6 - add separator before milestone reference in collapsed view
- 12869a9e - move progress bar from milestone summary into the sidebar
- 47af1203 - add CHANGELOG.md entry for !10096 (merged)
- 5af7dbe3 - update milestone page tests
- c8afe430 - Merge branch 'master' into update-droplab-to-webpack-version
- 06df12e9 - update droplab
- 1a4c60ef - Merge branch 'master' into feature/multi-level-container-registry-images
- 4213933d - fixed hover state
- 04990da1 - gave the border-radius of the todo count badge an extra nudge
- f09e3fe8 - Add a few pending specs for container repository
- 89d1a1c0 - Added specs for collapsed sidebar
- d79bdfcf - enable links to browse milsetone issuables in dashboard and group view
- 8dafec40 - use smaller font-weight in sidebar to match other sidebar content in gitlab
- 3b513675 - add start date to sidebar and display dates on group and dashboard views when possible
- 36714377 - combine milestone start and end dates in collapsed sidebar
-
8ec8aa14 - Use
:empty_projectwhere possible in mailer specs -
d281835a - Use Project
:repositorytrait where necessary in migration specs -
90e802cd - Use
:empty_projectwhere possible in policy specs -
b1222ebc - Use
:empty_projectwhere possible in serializer specs -
02ccf750 - Use Project
:repositorytrait where necessary in task specs -
985a0c39 - Use Project
:repositorytrait where necessary in view specs -
68e67189 - Use
:empty_projectwhere possible in worker specs - 38f092d1 - link to comm writers page, add what is a tech overview + example
- 6fdd595e - improve wording, update links
- d7b002f1 - add existing links to topics/index.md
- cde35cb2 - Add license to CE/doc
- dde56f8b - Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into new-guides-guidelines
- 550adacb - Fix custom protected branch pattern jumping scroll position to top
- 576ffef6 - Fix project title validation, prevent clicking on disabled button
- 25ac232f - Add changelog entry
- 625af168 - Add MR number to changelog
- aa637e69 - Update export button tooltip
- a055622a - Update tests
- 1c3c7fb2 - Add system_note_metadata model
- b15d9042 - Implement container repository path class
- bdc1e1b9 - Implement method matching container repository names
- f6f56ddd - Add back expandable folders behavior
- adec9194 - Adds expandable folder back.
- b64555d3 - Adds show all button
- c729d9da - Create metadata when creating system notes
- 598973c3 - Fixed inner page tabs not being scrollable
- 9a5556af - Fixed tabs on desktop being all over the place
- 6d14af2c - Added scrolling tabs to user#show
- c4be3460 - Fix API group/issues default state filter
- 28b8b92e - Fixed alignment on some pages
- 5de7eac6 - Add subnav height to sidebar scroll calculation
- bb910c3b - Make CI build to use optimistic locking only on status change
- 880b53e0 - Reset container width when switching to pipelines MR tab
- f63bae46 - Revert "Add license to CE/doc"
- 76119cb1 - Changes after review
- 5cad1401 - Fix broken test
- 8dd2da02 - Update docs regarding visibility lib
- d8569440 - There might be ps utilities out there, that assume 80chars instead
- 3bb0a9c8 - use correct first/last symbols in vue pagination component
- 4582f388 - fix URL
- b7690b29 - better intro to topics
- dd489351 - improve wording, move "see also" to "dev docs"
- df9fb04f - add link to "writing docs" , fix typo
- 3e5ea1cb - Merge branch 'new-guides-guidelines' of gitlab.com:gitlab-org/gitlab-ce into new-guides-guidelines
- 4f9d279b - capitalization
- a2f37f8b - oops - remove html element
- 0d267024 - Fix links and do some refactoring
- 2c26b9d1 - Update styles to bind tooltips to button wrapper
- e71a6c90 - Show BS Tooltips on disabled GitLab export button
- 1cc9bf86 - Make ChatNames::FindUserService stable by not checking a precise time
- 1e4f64d2 - Merge branch '29950-vue-pagination-icons' into 'master'
- 85847988 - Fix rubocop offense in container registry path class
- 95faf5f5 - Use new registry path class to match repository project
- a222486c - Rename method for checking tags in container repository
- b20ba361 - Merge branch 'new-guides-guidelines' into 'master'
- 64009175 - Add changelog
- 5a7f8cb5 - Add readability improvements to registry auth specs
- 06bae003 - Make container repository path code more readable
- 3bfc05be - Use container repository path inside auth service
- 313e35e8 - Remove container images destroy service class
- b0e18eaf - Merge branch 'optimistic-locking-ci-status-change' into 'master'
- 6dd76954 - Labels support color names in backend
- 03611b91 - Merge branch '28424-labels-support-color-names-in-backend' into 'master'
- 5e9f0bea - Changes after review
- 4407d3cf - Add comment to container registry auth service
- c837da34 - Helper method for storage path stripping
- 8f50ef5e - Separate GRPC channels per repository storage
- eee07f1c - Expand relative paths in storages
- 1904c80f - Change socket_path to gitaly_address
- 6b8c2ea8 - Allow backup tests to run locally
- 65b68338 - Fix custom hooks restore
- 340a6f86 - Add 9.1 update guide with Gitaly instructions
- 03c24c33 - Merge branch '23655-api-group-issues' into 'master'
- 412c9e8b - Merge branch 'create-collapsed-todo-button' into 'master'
- 76a15db4 - Merge branch '29832-fix-transient-failure' into 'master'
- feb7092e - Add tip about general git clone authentication.
- a74a6cfd - Create todos only for new mentions
- a1cd443b - Remove author from changelog
- 4d9cc941 - Merge branch 'gitaly-socket-per-shard' into 'master'
- bcebae31 - Remove jQuery from IPython notebook viewer
- d3ab245a - Adds tests that were only in EE
- c189bf11 - Merge branch '29828-change-search-hint-in-new-filters' into 'master'
- a9855fbc - Adds container option for tooltip to prevent the button from losing round corners
- b351a77a - Merge branch 'fix_rake_gitlab_check_sidekiq' into 'master'
- 5906a256 - Merge branch '29830-build-scroll-indicator' into 'master'
- ac67ce85 - Merge branch 'scrollable-secondary-tabs' into 'master'
- 5107f6b3 - Fix linking to new issue with selected template
- 79275ca0 - Merge branch '30149-fix-protected-branch-scroll-to-to-top' into 'master'
- fd167f22 - Fix admin projects page in admin area
- 5d3adcf2 - Merge branch 'fix-admin-projects' into 'master'
- 8db88bdf - Prep for moving droplab to npm
- 48a30a7a - prever #count over #size when calculating issue/mr totals
- 4cf16426 - Merge branch 'remove-jquery-from-notebook-viewer' into 'master'
- 1af15e0a - Update CHANGELOG.md for 9.0.2
- 9aedf9c4 - Monkey patch the Spinach StdoutReporter to show scenario locations
- d08d12ae - Add shortcuts and counters to MRs and issues in navbar
- 3e1fb2a5 - Merge branch '29866-navbar-counters' into 'master'
- f7fefe82 - Merge branch '23674-simplify-milestone-summary' into 'master'
- 20deca7c - Add download attribute to download links
- 1ccf4af3 - Merge branch '29539-fix-pipelines-container-width-with-parallel-diff' into 'master'
- 97a5e91b - Merge remote-tracking branch 'dev/master'
- 60c0c0f3 - Merge branch '29843-project-subgroup-transfer' into 'security'
- 91f43587 - Merge branch 'jej-group-name-disclosure' into 'security'
- c71831e8 - Added worksheets support to notebook viewer
- 80b621bc - Fixed a gap underneath the scrolling inner page links
- 68aa43fd - Merge branch '24784-system-notes-meta-data' into 'master'
-
53ef1de4 - Fix production admin fixture to use the new
Users::CreateService - bbc097cb - bumps gitlab shell version
- 53819c5a - Support >1 path in Gitlab::Git::Repository#log
- 0b1c7eea - Test docs internal links check
- eb367c46 - Merge branch 'test-doc-image' into 'master'
- a33b376d - Merge branch 'bump-gitlab-shell-version' into 'master'
- aa97ee54 - Merge branch 'update-eyeballs-docs' into 'master'
- 89ecd8ab - Merge branch '28799-todo-creation' into 'master'
- 5920b4a5 - Merge branch '26595-fix-issue-preselected-template' into 'master'
- 031122eb - Add container repository create service with specs
- 003a51d1 - Check container repository exists for a given path
- c7403521 - Merge branch '30248-fix-production-admin-fixture' into 'master'
- 5b84708d - Merge branch 'tc-cleanup-application-settings-spec' into 'master'
- 03538558 - Merge branch 'rs-empty-project-misc' into 'master'
- 7faafa5a - Merge branch 'rs-spinach-reporter' into 'master'
- c5eb5aa9 - group links select2 infinite scroll
- bee8b242 - Merge branch 'group-links-select2-infinite-scroll' into 'master'
- 4d3b5d52 - Merge branch 'patch-15' into 'master'
-
dc15abaa - Remove unnecessary ORDER BY clause from
forked_to_project_idsubquery - 024d8be0 - Merge branch '30063-builds-sidebar-stutter' into 'master'
- 236c9c17 - Simplify how we create container registry resources
- 7d3d1ec5 - Create container repository on successful push auth
- fffc8a59 - Show full container repository path in the UI
- cf042068 - Do not allow registry requests for invalid repositories
- ecfbfbf4 - Merge branch 'ipython-notebook-viewer-improvements' into 'master'
- 1ea0ce82 - Make GitLab use Gitaly for commit_is_ancestor
- bf0590b3 - Merge branch 'allow-multiple-paths-in-repository-log' into 'master'
- 8f93280e - Merge branch '29883-retry-button' into 'master'
- 8a0753a5 - Don't clean up the gitlab-test-fork_bare repo
- 40a94eb7 - Merge branch '30284-fix-repo-clean-rules' into 'master'
- 75a6ecaf - Fix the docs:check:links job
- 5e48bf8e - Update dpl CI example
- 6ff5e7f7 - Merge branch 'fix-docs-check-links' into 'master'
- 9bac3bfc - Allow users to import GitHub projects to subgroups
- 678d7e6b - Merge branch '30289-allow-users-to-import-github-projects-to-subgroups' into 'master'
- bcb0a554 - Merge branch '24861-stringify-group-member-details' into 'master'
- ac01a1b1 - 20914 Limits line length for project home page
- ced1bbab - Eliminate unnecessary queries that add ~500 ms of load time for a large issue
- fd097fa9 - Handle parsing OpenBSD ps output properly to display sidekiq
- 653d5f49 - Fix link to Jira service documentation
- a71e777b - Merge branch 'fix_admin_monitoring_background' into 'master'
- 7b708c65 - Merge branch 'sh-fix-unnecessary-queries' into 'master'
- 75fe1277 - Merge branch 'docs/ci-dpl-example' into 'master'
- 600bbe15 - Fix rubocop offense in registry path specs
- 9a0f96f9 - Add metrics button to Environment Overview page
- acc2a03d - Merge branch '29341-add-metrics-button-env-overview' into 'master'
- e559283c - Increase Capybara's timeout
- f659c406 - Eager-load the Capybara server to prevent timeouts
- a7466af3 - Improve code related to removing container image tags
- db749d5d - Adds tests for scoped tabs
- 60cdd2bc - Add specs for container repository factory method
- 4726ff9d - Add test example for invalid registry access request
- adb1cf82 - Merge branch '29929-jira-doc' into 'master'
- 2778c8f3 - Updating documentation to include a missing step in the update procedure
- 41956773 - Reorganize container repository controllers and views
- 53b21c1e - Merge branch 'forked-subquery-order' into 'master'
- f32d269c - Remove unused method from container registry client
- 00319e59 - Move code related to registry to multiple controllers
- d2283f4f - Backport API changes needed to fix sticking in EE
- 2fa56074 - Properly eagerly-load the Capybara server for JS feature specs only
- b0ab0e4e - Refactor SearchController#show
- 47cc1fea - Merge branch '28812-refactor-search-controller-show' into 'master'
- 83d1fe9b - Add serveral minor improvements to container registry
- b700a84e - Log errors in UpdatePagesService
- a3c926af - 30276 Move issue, mr, todos next to profile dropdown in top nav
- fc7454d8 - Merge branch 'nav-weird-gap-fix' into 'master'
- 3fb5c163 - Merge branch 'doc-upgrade-8.2-to-8.3' into 'master'
- b9adf92f - Prevent users from disconnecting gitlab account from CAS
- 32161042 - Merge branch '30276-move-top-badges' into 'master'
- 1a416a42 - Database migrations for protected tags
- 91ed8ed6 - Protected tags copy/paste from protected branches
- f51eac1d - Settings::RepositoryController includes protected tags in JS
- 18b445ad - Protected tags can be added/listed via UI
- b5fce1d5 - Removed unnecessary table ‘protected_tag_merge_access_levels’
- e3fbcd00 - Protected Tags enforced over git
- ab46353f - Added ProtectedTags#show page
- 553cf9ea - Added ‘protected’ label and disabled delete button for tags index/show
- 5191285c - Merge branch 'add-download-attr' into 'master'
- b54acba8 - Merge branch '25556-prevent-users-from-disconnecting-gitlab-account-from-cas' into 'master'
- 731d574d - Merge branch '30236-fix-capybara-timeouts' into 'master'
- 0d314840 - Add long polling diagrams
- 6de54010 - Merge branch '20914-project-home-width' into 'master'
- c0564c54 - Fix Spinach and Capybara dependencies
- 9fc17f6f - Merge branch 'sh-fix-capybara-features' into 'master'
- 0a09925d - Enable Style/Proc cop for rubocop
- bf64582f - Fix warning when cloning repo that already exists
- ca12079a - Remove code deprecated in pipeline process service
- 068f4b47 - Add changelog entry for deprecating legacy pipelines
- ed5d59d4 - Fix symlink icon in project tree
- 8a71d40e - Fix race condition where a namespace would be deleted before a project was deleted
- 6a2d022d - Delete users asynchronously
- 66f91aac - Fix N+1 query in loading pipelines in merge requests
- 38a108ca - Fix a few N+1 queries identified by Bullet
- 6811adaf - Relax constraint on Wiki IDs, since subdirectories can contain spaces
- af0c08b6 - Fix redirection after login when the referer have params
- 6bffef88 - Add a wait_for_ajax call to ensure Todos page cleans up properly
- fee49c99 - Merge branch 'fix-nplus-query-pipelines' into 'master'
- e7e93072 - Merge branch 'use-gitaly-commit-is-ancestor' into 'master'
- 2332bf34 - Remove unnecessary ORDER BY clause when updating todos
- 85e1fa8e - ProtectedTagEdit class for edit protected tags
- 551dea7e - Protected Tags List initializer
- bbb09fea - Export Protected Tags Editing classes
- 8d232b2f - Initialize Protected Tags Edit functionality
- 48150f27 - Render Push levels dropdown
- df54560f - Increase dropdown width within Tags list
- a7c71c7f - Update column widths
- 9c376300 - Fix a transient failure caused by FFaker
- fc550b39 - Merge branch 'master' into feature/multi-level-container-registry-images
- 058dfbb0 - Fixed user profile tabs causing the page to scroll
- 662d2e68 - Refactor feature specs for container registry
- 10b0fb1b - Remove redundant stubs from container image tag specs
- 01280a5a - Add missing test example for container repository tags
- 21546dad - Fixed issue boards having a vertical scrollbar
- 1a47986b - Check registry repository name against regexp
- 76b2fa3e - Fixes method not replacing URL parameters correctly
- 20b54b13 - Clean history state after each test
- c4d4f4d8 - Clean history after every test that changes history
- 670e1d74 - Change order of specs
- e10dae3e - Improve code in container repository path class
- 6fefa794 - Validate uniqueness of container repository name
- fee8dcde - Merge branch 'todo-update-order' into 'master'
- a3e65ef0 - Fix GitHub importer for PRs of deleted forked repositories
- 59588eba - Prefixes source branch name with short SHA to avoid collision
- 291bd873 - One more change to the branch names to preserve metadata
- 148068a8 - Fix specs
- 0d2f696c - Changelog
- c8273ba8 - Fix BrachFormatter for removed users
- 3c75ee28 - Minor refactor
- 3ac5e9eb - Improve specs examples
- d5f34094 - Fix specs
- fd30b3d4 - Ensure root container repository when visiting registry
- 8a6104d0 - Merge branch '29669-redirect-referer-params' into 'master'
- 0af4cbc5 - Simplify container repository build method specs
- cfbbdde3 - Merge branch '30264-fix-vue-pagination' into 'master'
- 3ed43ab8 - Merge branch 'sh-fix-todos-spinach-failure' into 'master'
- e0a9adfb - Merge branch 'sh-relax-wiki-slug-constraint' into 'master'
- 88812ce2 - Use gitaly 0.5.0
- 13487809 - Pass Gitaly Repository messages to workhorse
- 2faf955c - Merge branch '30211-fix-transient-failure' into 'master'
- 2fa10f57 - fix spelling CI_REPOSITORY_URL (line:355) gitab-ci-token to gitlab-ci-token.
- a1805cbc - Quiet pipeline emails
- 9543025e - Introduce "polling_interval_multiplier" as application setting
- b90f83e9 - Start adding profile icons
- 63345756 - Differentiate between event types
- 32bb33f7 - Change color of icons
- 99ff4d30 - Add deleted branch icon
- c998ce66 - Add changelog
- d4377b8c - Update commit icon; fix specs
- 059e11d8 - Fix race condition in namespace directory creation
- baa00d54 - Refactor container registry repository tag stubs
- fc5eb315 - Fix Rubocop offenses in code related to the registry
- feb3f306 - Merge branch 'bvl-cleanup-repos' into 'master'
- dcbd090c - Merge branch 'fix-nplusone-queries' into 'master'
- ff3703f5 - Merge branch 'sh-fix-destroy-user-race' into 'master'
- 41396031 - Merge branch '29541-fix-github-importer-deleted-fork' into 'master'
- a9b221d9 - Refine method for checking project registry tags
- e9d5e95c - Revert changes in services related to moving projects
- 325908ad - Remove changes unnecessary changes from namespace model
- b23b76d8 - Merge branch 'workhorse-gitaly-repository' into 'master'
- d2a9c5d8 - Remove unecessary changes from project transfer service
- 872b3215 - Merge branch 'introduce-base-polling-interval' into 'master'
- 2fceb437 - Merge branch 'master' into 'master'
- f2238a9b - Added the following ux improvements:
- df3c8345 - Readded missing statement from the rebase
- b076d034 - Hover lines are now synced up when hovering in any graph
- 5b0890ed - Legend text is now bolded also the Y legend text has a transparent background
- 8efd2301 - Fixed prometheus_graph_spec.js and scss-linters
- 902d2600 - Added a number input to provide a way to format the number of
- dff378d7 - Added CHANGELOG
- b4795830 - Added a formatRelevantDigits text utility
- d745876e - Code corrections with a helper and a variable
- 2797afd3 - Delete unused icons; add empty lines to svg files
- b2700e64 - Merge branch '22303-symbolic-in-tree' into 'master'
- 65f3d506 - Extract ProtectedRef Concern
- b8c7bef5 - Extracted ProtectableDropdown to clean up Project#open_branches
- 1b85c5a7 - Merge branch 'master' into tc-fix-unplayable-build-action-404
- 3069a2c9 - Removed formatRelevantDigits from text_utils.js and added it to a new file number_utils.js
- d663b8de - Fixes milestone/merge_request API endpoint to really scope the results
- 39753bfb - Add feature flags for enabling (Upload|Receive)Pack for Gitaly
- 09751c75 - Add support for Gitaly calls over TCP connection
- ca6a7f1e - Merge branch 'style-proc-cop' into 'master'
- 4e351678 - Don't use FFaker in factories, use sequences instead
- 5f7cb263 - Fix the AbuseReport seeder
- 169dc4ce - Fix brittle specs
- 58fe40fb - Don't use FFaker in factories, use sequences instead
- 5388bb1c - Ensure the AbuseReport fixtures create unique reported users
-
bf69e629 - Ensure user has a unique username otherwise
user10would matchuser1 - 3db1b959 - Buttons will be disabled when playable key is false
- 7f32ad70 - Fix blob highlighting in search
- f564cbb2 - Make file templates easy to use and discover
- 97c49b84 - Merge branch '25332-make-file-templates-easy-to-use-and-discover' into 'master'
- bf3cc824 - Moved Project#protected_branch? to ProtectedBranch, similar for tags
- 4f71c29c - Moved default_branch_protected? out of Project
- 3380ee71 - Fix container issue when switching parallel "Changes" MR tab before done loading
- 04a50bd9 - Removed protected_tags_array
- 336ba94a - Fetch GitHub project as a mirror to get all refs at once
- 20486593 - Skip MR metrics when importing projects from GitHub
- a9e432d6 - Remove unused include from RepositoryImportWorker
- 0b7d10fb - Add CHANGELOG
- a6affc66 - Rename skip_metrics to imported on the importable concern
- 6e64071e - Fix GitHub pull request formatter spec
- 35fe9c66 - Move methods that are not related to mirroring to the repository model
- 6143642a - Refactoring Projects::ImportService
- 35b719f6 - Use delegation in ProtectedRef concern
- 9f4b8dba - Clean up non TODO rubocop errors
- 1d6ddb05 - Fix namespace specs related to container registry
- 4fab9f24 - Fix documentation related to container registry
- ff9eb304 - Set the right timeout for Gitlab::Shell#fetch_remote
- a9af8625 - Fix Rubocop offenses
- 103a2a9a - Merge branch 'feature/add-feature-flags-for-upload-receive-pack' into 'master'
- e98536fb - Merge branch 'feature/support-grpc-calls-over-tcp-conn' into 'master'
- 3c91841d - Created ProtectedRefsController to reduce Tags/Branches duplication
- c2b35320 - Merge branch 'namespace-race-condition' into 'master'
- e473a907 - Merge branch 'fix/gb/remove-deprecated-pipeline-processing-code' into 'master'
- ff2713a5 - Fix typos in ProtectedRef concern and whitespace detected by rubocop
-
f61ded82 - Enable the
bullet_loggersetting; enableraisein test environment - d9aca741 - Merge branch 'fix-github-importer-slowness' into 'master'
- ecd75216 - adds git terminal prompt env var to application rb
- e3f88e68 - Remove index for users.current sign in at
- eccb9536 - Ensure users have a short username otherwise a click event is triggered outside the search field
- 5f7e671f - Merge branch 'pages-debug-log' into 'master'
- a3b1ff40 - Merge branch 'rs-bullet-raise' into 'master'
- d5acb69e - Protected Tags prevents all updates instead of just force pushes.
- e97d1ae0 - Fix a Knapsack issue that would load support/capybara.rb before support/env.rb
- aea21a12 - Merge branch 'quiet-pipelines' into 'master'
- 90c8bb83 - Fixed developers_can_push in RepoBranch API entity
- 1e15444a - Cleanup & tests for UserAccess#can_create_tag?
- 3bb3a688 - Attempt to fix import/export of push_access_levels for protected tags
- 2fd089a2 - Merge branch '29241-fix-transient-failure' into 'master'
- fa65b65b - Merge branch '29643-stop-using-ffaker-in-factories' into 'master'
- f9e849c0 - Cleaned up duplication with ProtectedRefAccess concern
- 07d7d8e6 - Renamed ProtectedTag push_access_levels to create_access_levels
- d85471ac - Fixed UserAccess#can_create_tag? after create_access_levels rename
- d7e3fadb - Ensure we generate unique usernames otherwise validations fail
- b57ed57f - Merge branch 'rc/fix-spinach-plus-knapsack-properly' into 'master'
- 5bff1af5 - refactor and fix eslint violations in behaviors directory
- 77dcb1f8 - consolidate all behavior imports into an index.js file
- d037a2e9 - Fix typo
- 7e46d0a9 - Fix container registry controller specs
- 5f7ebfb9 - Merge branch 'rc/fix-transient-failures-following-no-ffaker' into 'master'
- 008441c4 - Improve container registry repository view partials
- 59b5843e - Improve wording in registry notifications in the UI
- 7cf91f7b - Improve wording in partials related to the registry
- 97c6cf59 - Swap method names in containe registry path class
- 1c91d52a - Remove unneeded char in registry repository path
-
d4f3ce5e - Update patch_versions.md, add
yarn:installinClean up assets and cachecommand. - d67d43d1 - Split status and confidentiality action
- e6ffb158 - Don't autofill kubernetes namespace
- e52b1df1 - Remove useless queries with false conditions (e.g 1=0)
- cb2ce845 - Remove legacy registry tags when deleting a project
- f60820ed - Fix wording in registry tags controller notifications
- 666ba382 - Simplify registry-related code in project model
- 33329d40 - Fix project specs related to container registry
- b03f1699 - Extend registry docs regarding multi-level repositories
- 5efd6794 - Merge branch 'backport-sticking-api-helper-changes' into 'master'
- d56e4222 - Disable support for Gitaly PostReceivePack
- 44321b1a - Merge branch 'master' into feature/multi-level-container-registry-images
- ec28f0b5 - Add changelog entry for multi-level image repositories
- 099acf71 - Backport differences in global search from EE to CE
- f5b8dcf1 - Bump Gitaly server version to 0.5.0
- ae20a1a2 - Merge branch '24784-system-notes-icons' into 'master'
- c5dae616 - Merge branch 'remove_index_for_users.current_sign_in_at' into 'master'
- 97313fdd - Merge branch 'master' into 'master'
- ea35b119 - Merge branch 'sh-add-polling-images' into 'master'
- 3e663a24 - Merge branch '29670-jira-integration-documentation-improvment' into 'master'
- 2f939b4a - Fix container registry specs after changing texts
- 95188e72 - Merge branch 'backport-es-global-search-difference' into 'master'
- 7f8f927a - Merge branch 'zj-kube-service-auto-fill' into 'master'
- 5197b011 - Fixes broken lints
- 796d65f1 - Merge branch '29492-useless-queries' into 'master'
- 22d68f2b - Fix HAML lint offense in repository image partial
- ca94d200 - Pass GitalyAddress to workhorse
- 382060b9 - Merge branch '24187-set-git-terminal-prompt-env-var-in-initializer' into 'master'
- 7bf1881f - list recommended version of PostgreSQL
- 09617287 - Merge branch 'patch-17' into 'master'
- 9f9a7a2d - Added ProtectedTag to import/export son and safe_model_attributes
- 3301f4a2 - Merge branch 'feature/bump-gitaly-server-version' into 'master'
- 1d96b01f - Merge branch 'fix/disable-gitaly-post-receive-pack' into 'master'
- 10c76853 - Merge branch 'remove-unused-icons' into 'master'
- 267cd3e3 - Incorporate Gitaly client for refs service
- a46cca2e - Merge branch 'environment-performance-improvements' into 'master'
- 2d3987e3 - Fetch the default number of commits (20) for docs:check jobs
- 20e3ed60 - Merge branch 'workhorse-gitaly-address' into 'master'
- 6c6eef93 - Merge branch '30400-fix-blob-highlighting-in-search' into 'master'
- 82836af4 - Merge branch 'issue-boards-scrollbars' into 'master'
- 22d7ae80 - Fix issues importing forked projects
- 93e36d56 - Merge branch 'fix/import-fork' into 'master'
- 93de37ce - Merge branch 'bug/api_milestone_merge_requests_scope' into 'master'
-
3d61609c - Use
sign_ininstead oflogin_aswhen we're not testing login flow - a766f60a - Inlude the password_automatically_check param as permitted config in the user create_service
- d8cbe979 - Merge branch '30451-fix-docs-check-jobs-shallow-fetch' into 'master'
- 62521f20 - Add rake task that prints TOML storage configuration
- 4461e708 - Refactor test_utils bundle
- 0a4b853f - Merge branch 'refactor_simulate_drag' into 'master'
- c81ef304 - add auto-cancel for pending pipelines on branch, if they are not HEAD
-
c77b1cb0 - add
does not cancel HEAD pipelinespec -
b1dc850a - move
auto_cancelable_pipelinesmethod tocreate_pipeline_service.rb - 9bdb869a - fix typo
- 67f27a1c - change order of enum options in auto_cancel_pending_pipelines
- 40f67c1d - more brief way of get parent commit
-
a4d08e6b - rename
auto_canceled_byand add foreign key - 2eb7ae9e - add auto_canceled_by_id to safe_model_attributes.yml
- effcbaf3 - fix on_delete
- b5c28699 - fix rubocop
- aa4a9b9b - fix fallen import_export spec
- 2d7bc695 - adds tooltips into several places
- ebf05201 - add tooltip on badge in pipelines index
- 29db8ab9 - fix linter error
-
d2f2168b - remove
a pending pipelineshared example - b49e7966 - refactor spec
- 4f748f74 - replace on_delete in migration with database type related expression
- 63dbdb9f - add presenter for status badge
- a0de26f2 - fix migration error
-
86d8c2a7 - remove redundant
pipeline - 3a7352fd - remove unnecessary space
- 14722b66 - rename pipeline_presenter
- b9f7d4b4 - split up migrations
- 25756618 - replace helper with decorator
- 81ac42bd - Merge branch '29432-prevent-click-disabled-btn' into 'master'
- 251255e7 - Do not set closed_at to nil when issue is reopened
- 44a5c6b2 - Fix a transient spec failure in "Admin Health Check" feature spec
- 30253183 - Merge branch '28732-expandable-folders' into 'master'
- c9806b47 - extract build.pipeline as variable
- 050bafaa - Merge branch 'rs-sign-in-poc' into 'master'
- 41ff2e15 - Removes unused code
- 2d4fd769 - replaced one more helper with presenter
- 4dd841c9 - Merge branch 'fix-password-required-check' into 'master'
- 6910c908 - Backport changes of ee fix for transient failure in environments spec
- 55040241 - use a less memory-intensive sourcemap when running in CI
- d3ab818c - Merge branch '30461-fix-transient-failure' into 'master'
- bf305c3d - Merge branch 'simple-ci-sourcemaps' into 'master'
- ced322c5 - Merge branch 'backport-transient-failure-1567' into 'master'
- 7d43484d - Fix wiki commit message
- 48d4edd6 - Remove confusing placeholder for JIRA transition_id
- 54849afc - Handle SSH keys that have multiple spaces between each marker
- 4865a7ab - Enable creation of deploy keys with write access via the API
- 2316774d - Update CHANGELOG.md for 9.0.3
- d4d95ad3 - Merge branch 'sh-fix-ssh-keys-with-spaces' into 'master'
- 04e9dddf - Disclaimer for testing guide not be be used in prod
- 20e6670a - Merge branch 'issue_91_ee_backport' into 'master'
- 65ea732c - Merge branch 'fix_wiki_commit_message' into 'master'
- 4917df5e - Issue boards list template in JS file
- 3369232c - Added specs for board list component
- 6718c188 - Changed order in Vue file
- 474236e8 - Adds meaningful description to changelog entry
- d0821ae6 - Stop new merge request page tabs updating the URL
- ab79c76d - Removes the duplicated search icon in emoji menu
- bdcd23b2 - Create subgroups if they don't exist while importing projects
- 6831ee8f - Merge branch 'fix/import-namespace' into 'master'
- 2065d144 - Fix html structure to prevent tooltip from not hidding
- dd18faff - Merge branch 'issue-boards-list-template-in-js' into 'master'
- fd8a4078 - Load a preview of Sketch 43 files
- 32e2783f - Potential fix for intermittent spec failure in award emoji specs
- 7f8e0bce - Added mock deployment and monitoring service with environments fixtures
- 10a77824 - Merge branch 'mock-deployments' into 'master'
- 56cf0274 - Rename {create,inizialize}_raw_repository
- 31b8287a - Return an empty array when dependencies is an empty array
- a40e357f - Merge branch 'gitlab-ci-multi-runner-2284' into 'master'
- 0617876d - Fix subgroup repository disappearance if group was moved
- ee6f5002 - Improve container repository tags controller route
- ed0547b7 - Require container registry entities in controllers
- b31c5332 - Revert unneeded change in project destroy service
- b611da70 - Fix status when removing legacy tags from registry
- c753975b - Add some minor improvements into registry partials
- 7c519821 - MR empty state
- 8eb35066 - Deal with Rails autoload instance variable resets
- d4349ba6 - Merge branch '20841-getting-started-better-empty-state-for-merge-requests-view' into 'master'
- 000af871 - Remove redundant code from container registry classes
- 6b565f53 - Improve docs for multi-level container registry images
- efe2d96a - adds initial microsoft teams integration
- 7dd645e6 - add note message integration with microsoft teams
- 9bfa0a5f - adds remaining messages
- 05f69ef2 - adds microsoft team activity object and refactors code accordingly
- d197347d - Added droplab to yarn.lock and package.json
- 1e541815 - Improve migration for container repositories table
- fefd5a08 - Merge branch 'master' into update-droplab-to-webpack-version
- 35bafb37 - Convert value to string before setting Poll-Interval header
- 63a6453c - Use NamespaceValidator::WILDCARD_ROUTES in ETag caching middleware
- a63f4579 - Make group skip validation in the frontend
- 5771ee40 - Merge branch 'fix-groups-long-url' into 'master'
- c7132929 - Merge branch 'sketch-preview-files' into 'master'
- 7196adaa - Merge branch 'sh-fix-award-emoji-transient-spec' into 'master'
- 58371efb - Periodically mark projects that are stuck in importing as failed
- 189da6b4 - attempt to fix db failure
- 7c9a46bc - Revert schema.rb
- 0bd4c17e - attempt to fix migration
- 3bec6131 - Document how ETag caching middleware handles query parameters
- 90e0b2df - Use gitlab-workhorse 1.4.3
- 5077079f - Remove deprecated field from workhorse response
- 82dea6cf - Fix Rubocop offenses related to registry routes
- 32e9e24a - Merge branch 'wildcard-routes-in-etag-middleware' into 'master'
- 97667b83 - Merge branch 'docs-polling-query-params' into 'master'
- 56c3b286 - Refactor CI index page
- 5b53b283 - Reorganize CI examples, add more links
- 0a9eac59 - Fix broken link
- ef9cfcb5 - Separate Scala from Java in CI examples
- 44ec4002 - fix project authorizations migration issue
- dad30d6b - Use PDFLab to render PDFs in GitLab
- 34eea295 - Fix test and only show job status title if it's
- 280531a7 - Merge branch 'render-pdfs-in-gitlab' into 'master'
- fec40d78 - Merge branch 'emoji-menu-duplicated-search-icon' into 'master'
- 33deaaf3 - Remove tooltip from API and vue, follow up:
- 7348e0a1 - Ask people to create EE MRs on the 7th
- 06a20b87 - Updated droplab version to webpack version
- c2cb2fb4 - update droplab
- 8bdfee8b - Prep for moving droplab to npm
- 08bbb9fc - Add option to start a new discussion on an MR
- 336016fa - Satisfy Rubocop
- 9c30b0e9 - Fix some specs
- 15718352 - Fix merge conflict issue
- 76aa0bed - Fix field name
- f6f6aaf5 - Better notification emails for notes and (diff) discussions
- 80b2e18f - Enable discussions on issues, commits and snippets
- 79889a6a - Add specs
- 874413cf - Fix specs
- 2058e71e - Extract commonalities between DiffDiscussion and LegacyDiffDiscussion
- bb8cc946 - Don't use original_discussion_id
- fe26b8af - Correctly display multiple separate discussions on the same diff line
- 21e10888 - Address review comments
- afa53810 - Fix specs
- c319f211 - Address review comments
- 63c7801e - Remove and ignore notes.original_discussion_id column
- 3ff708f7 - Remove unused code
- 077a1571 - Add line breaks in long comments
- 2b92f910 - Added droplab to yarn.lock and package.json
- d59ddf51 - Large features by the 1st, small ones by the 3rd
- 7cb907cc - Add "search" optional param and docs for V4
- ebdfda69 - Merge branch 'gitaly-refs' into 'master'
- 016e1a29 - Restore schema
- f51adf8c - Add more tests for subgroups feature
- 271ab515 - Merge branch 'dz-fix-group-move' into 'master'
- 5e3fa025 - Added resolvable discussion frontend
- 00855926 - Move CommentTypeToggle use from gl_form to notes
- 09330dd1 - Remove unused code
- 6bf1780a - Add tests for relations and scopes, and setting
- e258e6f1 - Add test for presenters
- f7014cd5 - Add a test to make sure it's not auto-canceling
- 9c4a06a8 - Fix close buttob bug when toggling dropdown
- 5c687e23 - Merge branch 'convert-poll-interval-to-string' into 'master'
- 78a84421 - Merge branch 'workhorse-1.4.3' into 'master'
- 50a0fd03 - Merge branch '30195-document-search-param-on-api' into 'master'
- 08393eca - Merge branch 'docs/ci-index-page' into 'master'
- 9997c58f - Add remove_concurrent_index to database helper
- e3ce5b64 - Merge branch 'tc-fix-unplayable-build-action-404' into 'master'
- 4e3de96e - Merge branch 'gitaly-prevent-autoload' into 'master'
- b821ed6f - Update CHANGELOG.md for 9.0.4
- 11b350ee - Update CHANGELOG.md for 8.17.5
- 5fde7c6c - Update CHANGELOG.md for 8.16.9
- 1c783007 - Issue title realtime
- c25cf77d - Merge branch 'issue-title-vue-2' into 'master'
- 5f947856 - Make issue-from-discussion description text more consistent
- 3871941d - Move discussion button to its own file
- 46f3e37d - Customize Start discussion message according to if the noteable can be resolvable
- 9ee6b0ce - Display secondary button only in resolvable noteables
- 4d70fc58 - Do not initialize comment type toggle if form is not available
- 99dec8e6 - Add class selector to make secondary button to work
- b47b6abf - Fix squared buttons by removing not needed CSS classes
- 2e8aa209 - Merge branch '30125-markdown-security'
- 29d8b4ee - Merge branch '29364-private-projects-mr-fix'
- 0d8fba4e - Merge branch 'path-disclosure-proj-import-export' into 'security'
- b80653bb - Merge branch 'open-redirect-host-fix' into 'security'
- d687f643 - Merge branch 'open-redirect-fix-continue-to' into 'security'
- aaa49c2c - Merge remote-tracking branch 'dev/master'
- d9dedac8 - Be more specific with selector
- 4bc70127 - Make it possible to preview pipeline success/failed emails
- 717547e8 - Clearly show who triggered the pipeline in email
- b996a82f - ProjectsFinder should handle more options
- d5102cf7 - Search for opened MRs - include reopened MRs
- 5200686b - Disable submit button and dropdown when submitt comment form
- ec3a50f1 - Merge remote-tracking branch 'upstream/master' into 8998_skip_pending_commits_if_not_head
- 4a030326 - Fix rolling back for MySQL
- 06b4ea24 - Fix a view test by using presenter
- a6c61599 - Merge branch 'master' into update-droplab-to-webpack-version
- 94716c27 - remove unnecessary lease as cron job
- 57374fea - Move AuthHelper#two_factor_skippable? into ApplicationController
- a3430f01 - Support 2FA requirement per-group
- 7140e09e - Extract 2FA-related code from ApplicationController
- 8e665140 - Rename check_2fa_requirement to check_two_factor_requirement
- a49c5d18 - Rename skip_tfa session variable to skip_two_factor
- b7ca7330 - state the reason to the user for the required 2fa
- 5ea4e34f - add method to get a full routable hierarchy
- 20575859 - check all groups for 2fa requirement
-
1735ed61 - rename cache db column with
_cachedsuffix - 63e61cfd - use more explicit and explanatory sql statement
- 01be21d4 - user#update_two_factor_requirement is public
- 714c408f - Add minor improvements to container registry code
-
678672b0 - Bundle renamed to
index.js - 115d4a41 - Convert to pure ES6 class
-
92b75704 - Re-export classes using ES6
export - 59be20f0 - Import Protected Tags classes
- 49bdd8d6 - Merge branch 'tc-fix-pipeline-recipient' into 'master'
- 3c414a9f - Update bundle path for Protected Tags bundle
- 5e67b2fd - Wait for the PDF to be loaded before doing anything
- cd5b36d0 - Add constructor doc, toggle helper
- a9186d07 - Fixed close button text
- 0ec3a031 - Show the test coverage if it is available
- 18506d4b - Merge branch 'master' into '18471-restrict-tag-pushes-protected-tags'
- 0fc361c4 - Use Gitaly for Environment#first_deployment_for
- ae7ec004 - rubocop
- 47907a41 - Cleanup
- f16377e7 - Protected Tags backend review changes
- e992799c - STL file viewer
- 38c90cdc - Merge branch '3d-file-viewer' into 'master'
- 70982bb4 - Hopefully this works
- d7e3f232 - Merge branch '30021-api-deploy_keys-can_push-is-not-honoured' into 'master'
- 32db15b2 - Merge branch '28810-projectfinder-should-handle-more-options' into 'master'
- 7083d381 - Added feature specs
- 6d7a5248 - Merge branch 'master' into feature/multi-level-container-registry-images
- 28a4e9d8 - Show CI status as Favicon on Pipelines, Job and MR pages
- 9c2979ec - Merge branch '12818-ci-status-as-favicon' into 'master'
- dc20dd1b - Merge branch 'add_remove_concurrent_index_to_database_helper' into 'master'
- 61854294 - Merge branch 'fix/gh-import-status-check' into 'master'
- 7db45ca3 - Added droplab back to static assets
- 8af788e0 - Disable invalid service templates (again)
- aba1c226 - Merge branch '30493-env-deploy-tooltip' into 'master'
- 75ac2699 - Merge branch 'update-droplab-to-webpack-version' into new-resolvable-discussion
- a1db7c5b - Merge branch 'pdf-js-spec-loading-wait' into 'master'
- d062af91 - Merge branch '30291-reopen-mr' into 'master'
- 12566f3f - Link to docs site for file in doc/
- 7f2a2008 - Fix RuboCop for removing index
- 98a4aca6 - Merge remote-tracking branch 'upstream/master' into 8998_skip_pending_commits_if_not_head
- 24507da4 - Remove individual modal width styles
- 2a18425e - phil review changes
- 98f59fc2 - Merge branch 'master' into update-droplab-to-webpack-version
- 062806e4 - Define baseline for test for pipelines serializer
- 3015e768 - Revert "Reverse pipelines controller changes"
- 8a1c12aa - Introduce endpoint optimisations
- 66d03aae - Fixed error handling
- 894f01cd - Include endpoint in metrics for ETag caching middleware
- fca0097c - Github import rake task
- 9cee280d - Merge branch 'update-droplab-to-webpack-version' into new-resolvable-discussion
- d0e1354f - Merge branch 'feature/gh-rake-task' into 'master'
- b828a98c - Optimise includes
- 62919a17 - Update tests and associations
- 93f9e71b - Further optimise queries
- 79d299f9 - Introduced empty/error UX states to environments monitoring.
- 15429ea5 - Merge branch 'add-error-empty-states' into 'master'
- 72580f07 - Move a user's merge requests to the ghost user.
- 97cbf7c2 - Move a user's notes to the ghost user
- 6a065074 - Fix a bug with the User#abuse_report association.
- 68298754 - Move a user's abuse reports to the ghost user
- 3e1a1242 - Move a user's award emoji to the ghost user
- 07f365e3 - Add CHANGELOG entry for !10467 (merged)
- e152f3f3 - Add documentation around migrating records to the ghost user after user deletion.
- 057c0d7a - Also track auto-cancelling in jobs, detail:
- 227a664e - Next round
- 80c92649 - Award emoji button smiley animation
- 8199ff7b - Merge branch 'award-emoji-button-smiley-animation' into 'master'
- 38c324b9 - We don't have to save, transition would save for us
- ca9cded4 - Fixes as per feedback
- eba7c3c1 - Merge branch '29807-improve-triggers-edit-and-delete-buttons-alignment' into 'master'
- 3613e342 - Merge branch 'dz-inherit-create-group-permission' into 'master'
- 09a4c263 - Merge branch 'ee-mrs-on-freeze-date' into 'master'
- 2bc96e59 - Merge branch '30024-owner-can-t-initialize-git-repo-for-new-project-in-group' into 'master'
- 99e4431c - Update unit tests
- 29a7a8c7 - Merge branch 'user-page-horizontal-scrolling' into 'master'
- 1bed2c87 - Add missing tests and update test description
- 95ecbfed - Remove unused code
- cdfa17c4 - Use before_transition
- 1ac44911 - Bump schema version
- 46e4ed6b - Merge branch '29470-make-modal-sizes-consistent-and-mobile-friendly' into 'master'
- 5f715f1d - Add scheduled_trigger model. Add cron parser. Plus, specs.
- 37d6d1e4 - basic components
- 531af92d - Add config for worker
- 8f798e81 - Rollback
- b4da589e - Remove old migration file
- 4c2435f5 - Add ref to ci_triggers
- e32c1a5c - Add ci_trigger_schedules table
- c426763c - Rename ScheduledTrigger to TriggerSchedule. Because table structure changed.
- 3d1bc4a4 - Fixed strcture for db change
- 75f5e710 - Add rufus-scheduler to Gemfile
- 2a1a7310 - Add validation to Ci::TriggerSchedule (Halfway)
- 36ee4877 - Change configuration in gitlab.com as trigger_schedule_worker will perform twice a day
- da8db28d - Change configuration in gitlab.com as trigger_schedule_worker will perform twice a day 2
- 13bac4c2 - Use delegate for ref on ci_trigger
- d48658e3 - Use constraint for #validation
- 9573bb44 - real_next_run (WIP)
- d65c816e - Brush up
- 5720919c - Brush up 2
- 21cabf38 - Move real_next_run to helper
- 57d082f3 - Add validator
- d9574c0c - Maintain MR
- 62480461 - Fixed failed tests
- 934e9497 - Fix rubocop issues. Use add_concurrent_foreign_key.
- b5f252bd - Fix spec/factories_spec.rb
- 01cea0d5 - Suppress Import/Export function warnings. Add comment for confirmation.
- a2c4a2a2 - Resolve error on trigger.spec
- 1bd54949 - Improve cron_parser_spec
- 97cc6777 - Commentout check_cron_frequency
- a67aff6d - Add Import/Export Setting for trigger_schedule. Remove ref validation.
- f6be8c04 - Remove less_than_1_hour_from_now comments. Dry up def schedule_next_run!
- 27f981b2 - Improve real_next_run. Improve triggers_helper_spec.
- 914bef67 - Move Ci::CronParser to Gitlab::Ci::CronParser
- 3d3df097 - Dry up next_time_from. Move cron_parser_spec to appropriate location.
- 4949e2b2 - Separate cron_valid? and cron_time_zone_valid?
- 0c153af7 - Ommit begin block in try_parse_cron
- 4a5c6a8e - Rename cron_nightly_build to nightly
- f229290a - Remove triggers_helper. Add trigger_schedule_presenter.
- 1dbc888e - Remove TriggerSchedulePresenter. This will go in another MR.
- 4688eb47 - Rename cron_time_zone to cron_timezone. Separate add_concurrent_foreign_key.
- 1a244c64 - Remove next_run_at: nil from trigger_schedule_spec
- cc6ac794 - Define next_time as let in trigger_schedule_spec
- 3b58966b - Use parenthesis for respond_to :ref
- 31bd3962 - Add empty line in cron_parser.rb
- 7b09a484 - Fix unnecessary changes in schema.rb
- cb082ae2 - Improve instantiate recursion in cron_parser.rb
- c2c3ee1b - Clean up trigger_schedule_worker_spec.rb
- 12a5380f - Implement a offset calculation on cron_parser_spec
- 48e07eab - Improve trigger_schedule.rb
- 059ec792 - Use be_pending
- fff6afba - Use change direction in spec
- 9441c014 - Fix rubocop
- 7d17fcea - Fix projected import failing on missing relations
- abefedf5 - Correct dropdown width
- c3af43c3 - Merge branch 'add-dimension-etag-caching-metrics' into 'master'
- 397b9c8e - Add feature specs
- fd822643 - Merge branch 'use-gitaly-find-ref-name' into 'master'
- 7d543837 - Fix markdown table in API Issues docs
- b7ce488d - Recent search history for issues
- ce55999b - We no longer has has_command? method
- 163e9f99 - Fix indexes in container repositories table
- 64c1735c - Remove unnecesary style
- 7547e865 - Use preload because we don't want join here
- 553c784b - Ignore those optimization associations in import/export
- 542b0d8b - Use config.toml to configure Gitaly
- 503f8822 - Fix rubocop offenses
- 514dc1a0 - Merge branch 'feature/enforce-2fa-per-group' into 'master'
- cc656a11 - Refactor resolvability checks based on type
- 828d81ee - Optimise trace handling code to use streaming instead of full read
- df10507f - Merge branch 'update-trace-handling-code' into 'master'
- 3f60fe1a - Merge branch '27262-issue-recent-searches' into 'master'
- b42dc1a5 - Linking to edit file directly
- e3f2c010 - Merge branch '28899-linking-to-edit-file' into 'master'
- b85ddc84 - Fix typo
- 2f7ff6ea - Fix rubocop offence
- 9362f593 - Merge commit '46e4ed6b' into feature/multi-level…
- 86d5f1f8 - Merge branch '29128-profile-page-icons' into 'master'
- 1c42505b - Implement review comments from @DouweM for !10467 (merged).
- a39ff617 - Fix token test by specifying a static token
- 4f435c6c - Reload pipeline to make sure it's updated
- beedfc8d - Fix test by ignoring auto_canceled_by for jobs
- 173384f8 - Merge branch 'gitaly-config-toml' into 'master'
- 29cd3b0b - Fixed rubocop failure for the add_two_factor_columns_migration
- 5a4aee36 - Make sure that's canceled
- 99ff8165 - Add text to break up diagrams
- d6caa9d7 - Merge branch 'feature/multi-level-container-registry-images' into 'master'
- 1f404065 - adds relevant tests
- 9205caa3 - Merge branch 'tc-show-pipeline-coverage-if-avail' into 'master'
- bef1aca8 - Merge branch '28695-move-all-associated-records-to-ghost-user' into 'master'
- 1815d44a - Merge branch '2989-run-cicd-pipelines-on-a-schedule-idea1-basic-backend-implemen…
- bc3b0418 - Merge branch 'sh-improve-polling-text' into 'master'
- 1df9ac23 - Fix feature specs, still some to be done
- 1065ba40 - Merge branch 'new-resolvable-discussion' of gitlab.com:gitlab-org/gitlab-ce into…
- e28fc7b1 - Merge remote-tracking branch 'upstream/master' into 8998_skip_pending_commits_if_not_head
- 73cb71e4 - Merge branch 'rubocop-fix-migration-two-factor-columns' into 'master'
- 00e00cac - Merge branch 'microsoft-teams-integration' into 'master'
- 9d4b6f22 - Fix import export
- 727d8de2 - Fix "Generate new recovery codes using SSH" documentation link
- 57c353fc - Fix tests and review
- fc8ec950 - Corrected capitalizacion on various sections
- eb2d6a6e - Fixed rspec tests
- c2a987fb - Admin section capitalization fix
- 7997a0df - Dashboard section capitalization fix
- 0e325ea6 - Groups section capitalization fix
- 7592137f - Fix rspec and spinach tests
- c380d766 - Fixed button capitalisation for Projects in views
- 745058c0 - Added CHANGELOG
- 792f6ed1 - Merge branch 'master' into new-resolvable-discussion
- 37a7b099 - Merge remote-tracking branch 'origin/master' into optimise-pipelines
- a33aacd5 - Further fixes for feature spec
- 4ddf2089 - Merge branch 'new-resolvable-discussion' of gitlab.com:gitlab-org/gitlab-ce into…
- 126c6512 - Update schema.rb version
- 902054db - Fix within('#new_protected_tag') in protected tags spec
- 55811ac9 - Merge branch 'last-green-master' into 18471-restrict-tag-pushes-protected-tags
- 57d6346b - Moved the monitoring button inside the show view for the environments page
- 3dc8c312 - Fix selector for form wrapper
- 26a672da - Merge branch '18471-restrict-tag-pushes-protected-tags' of gitlab.com:gitlab-org…
- 12c18ee5 - Copy diff file path as GFM
- 69bf7bfa - Merge branch 'dm-copy-diff-file-title-as-gfm' into 'master'
- 8a5ca112 - Merge branch 'master' into '18471-restrict-tag-pushes-protected-tags'
- 923a2adc - Update issue board cards design
- 197dad2e - Merge branch 'update-issue-board-cards-design' into 'master'
- afb5f21a - Clean up troubleshooting section
- 5fbb9e95 - Merge branch 'optimise-pipelines' into 'master'
- 6f9fdebc - Adds polling function to pipelines table
- 90fc9237 - Updates polling function to guarantee we won't make a request while polling
- 788f3451 - Extend realtime for other pipelines tables
- 7c1bb6c3 - Fix broken build
- 386f9586 - Changes after review
- ebae1046 - Remove first call to API
- 847b9c82 - Use Etag caching for pipelines json
- 751dae58 - In case of Etag cache hit, the body should be empty
- 26e24bbe - Set the Etag cache polling interval
- 9e89c93e - Enable polling for pipelines table other pages
- f66e1c17 - Destroys pipeline table component when we change tabs in order to stop polling
- e6571ed9 - Check if a commit belongs to pipeline before trying to expire cache
- 0dd3ce62 - Fix broken spec
- 506d2097 - Update screenshot
- de3e0834 - Further fixes for feature spec
- 993c2071 - Update inputsetter
- 31c51c8c - Merge branch 'update-droplab-to-webpack-version' into new-resolvable-discussion
- 71eae208 - Add keyboard shortcuts to main menu.
- fac13e61 - Add changelog
-
cba47179 - Change shortcut to
n. - 82ababf0 - Fix layout of shortcut keys in dropdown
- 610ea22e - Map bindings to lowercase letters; only show key bindings when using keyboard shortcut
- e220eecb - Switch global shortcuts to shift; reuse key styles from help menu
- b19538d1 - Change shortcuts
- 86f3ae0c - Change todos shortcut to shift
- 04b69fac - Reorganize shortcut help menu
- cde0b27c - Fix shortcut specs
- d9ed9c6d - Adds ShortcutsDashboardNavigation to globals comment since its a global variable
- e9025c25 - Improve shortcuts code
- d7351cff - Reuse code
- 177c2139 - Fix broken spinach test
- 7eba42f5 - Update tests
- 518203d5 - Fixed specs
- d2aea4cd - Merge branch '29193-fix-switching-mr-changes-tab-before-loading' into 'master'
- 32e4a0f3 - Add system notes icon helper; add icons
- 6f7deb48 - Add remaining system note icons
- f3a39afc - Fix newline errors
- 087e8328 - Fix positioning of note icons
- 5c7953fb - Leave icon area blank if legacy note; remove diamond icon
- 2c9239fb - Change edit icon
- 25faa060 - Rewrite system note helper
- 31672df3 - Fix icon name error
- 8a574030 - Merge branch 'button-capitalization' into 'master'
- 496208c9 - Merge branch 'menu-shortcut' into 'master'
- 9db87fce - Protected tags changes from backend maintainer review
- 153531ff - Finish up feature spec
- f2f44579 - Renamed spec files
- bb4bc215 - Merge branch 'update-droplab-to-webpack-version' into new-resolvable-discussion
- 558cdc9f - Merge branch '24784-mr-system-notes' into 'master'
- 907b7541 - Fixed bugs and added tests
- 72419f3a - Documentation for protected tags
- ae62fc05 - Fixes failing spec
- 30c88499 - Merge branch 'load-svg-in-js' into 'master'
-
4bf6ffa5 - Remove
undefinedclass from.emoji-menu-list -
370fd105 - Removed
Milestone#is_empty? - d8a1ea0c - sidebar z-index above content area
- 6ea35f98 - Merge branch 'mr-new-page-changing-url' into 'master'
- f8fe64a6 - Merge remote-tracking branch 'upstream/master' into 8998_skip_pending_commits_if_not_head
- 38796f56 - Fix bad conflict resolution
- b9027887 - Merge branch '30575-update-prometheus-integration-documentation-for-9-1' into 'master'
- 5b2b42a4 - Merge branch '5983-realtime-pipelines-table' into 'master'
- c970fa97 - Merge branch 'docs/fix-md-table-in-api-issues' into 'master'
- 15e87cea - Merge branch '8998_skip_pending_commits_if_not_head' into 'master'
- 6ed59e12 - Hide header counters for issue/mr/todos if zero
- 60c121eb - Backport permissions and multi-line array to CE
- c3e43c9b - Add /-/readiness /-/liveness and /-/health_metrics endpoints to track application readiness
- 9216f59a - Merge branch '24240-prometheus_healthz' into 'master'
- 5991dfd3 - Fix new group button label in GitLab QA specs
- f87158af - Backport of EE changes in environments tests
- e4ac948c - Send more Gitaly::Repository fields
- 7ecc7f6a - Remove unused code
- 6a07a243 - Combine delegations in one line
- 6474c67d - Remove spaces
- 20d415a6 - Use Gitlab::Git::Repository#gitaly_... more
- fb7b0d6e - Merge branch 'master' into update-droplab-to-webpack-version
- 2f22890d - Merge branch 'update-droplab-to-webpack-version' into new-resolvable-discussion
- 8ca5afdf - FE: Resolve "Performance issues when processing large build traces with Ansi2html"
- 333a4c8c - Merge branch '27724-fe-update-trace-handling-code' into 'master'
- dca2aaaf - Merge branch 'feature/service-desk-be-backport' into 'master'
- 01c8bf38 - Merge branch '28574-jira-trigers' into 'master'
- 00e87532 - Doc: Search through GitLab
- aa8260d2 - Merge branch 'docs-search' into 'master'
- c19ad3d5 - Merge branch 'gitaly-repository-message' into 'master'
- 6f15e89a - Show Flash message above Tags list
- 780a8968 - Merge branch 'qa/gb/fix-new-group-button-label' into 'master'
- 18e2388d - Fixed issue button state bug
- dab60475 - Update droplab
- 75462cba - Merge branch 'update-droplab-to-webpack-version' into 'master'
- d88a238b - Merge branch 'dz-hide-zero-counter' into 'master'
- 7ccaa27f - Merge branch '30056-rename-milestones-empty' into 'master'
- 2548c155 - Add form for scheduled trigger
- 76c0364c - Use allow_destroy. Remove condtion from form.haml.
- ea8574fd - Add specs in triggers_spec.rb (Halfway)
- 4131ed2b - before_create :set_project. Now TriggerSchedule saves project from parent
- 2f5095c2 - Add def trigger_schedule in Trigger. Use persisted? for checling existance
- fb8c49db - create_params and update_params into trigger_params
- 1ae1d85c - N/A to None. Revert validates from validates_presence_of.
- 03088552 - Fix ref reference
- 034c8885 - Merge branch '30587-pipeline-icon-z' into 'master'
- 21a7aed9 - Update tests to cover trigger schedule
- 7cee650d - Update migrations
- 7461072f - Update code to remove no longer needed changes
- 4e3e51fe - Bump migration paths version
- 344001d7 - Simplify if
- 4d881ac6 - shows go back link only when history is available
- 052d200c - Merge branch '27580-fix-show-go-back' into 'master'
- 37e7fe2c - Merge branch 'metrics-button-misplaced' into 'master'
- 99918be7 - Added variable button fix
- 8fab8a95 - Merge branch 'zj-migration-paths-shift' into 'master'
- 2d246df5 - Merge branch '30496-remove-undefined-from-emoji-menu-list' into 'master'
- b70d828f - Merge branch 'master' into new-resolvable-discussion
- d5201119 - Fix test failures
- 8d3f7979 - Fix changelog
- 9082d1e0 - Rename Ci::PipelineStatus -> Ci::ProjectBuildStatus
- 47abf00b - Update project build status cache when transitioning
- a6d31300 - Wrap updating of cache after pipeline transition in class method
-
02072e17 - Rename
ProjectBuildStatus->ProjectPipelineStatus - 516a405e - Take the ref of a pipeline into account when caching status
-
9eded57d - Use
Ci::ExpirePipelineCacheServiceto setProjectPipelinestatus - 05339515 - Add link to list items
- bea1aba9 - Update schema.rb
- 2a771d57 - Fix view spec
- 0872b854 - Another round of code review
- ac355664 - Fixed duplicate jQuery AJAX spyon
- 46aadc5c - Merge branch '18471-restrict-tag-pushes-protected-tags' into 'master'
- 3ea4a139 - Yet, another errors
- 043a0ec0 - Clarify what an MR needs to be 'with' a maintainer
- d80f9036 - Fix creating discussion when diff view is set to parallel
- 8c161d7b - Fix bug where commit comment would not show up in the right discussion on the MR page
- 16a2eba5 - Count number of queries
- ed368f8c - Fix spec failure
- 8325d3fd - Fix firefox overflow css bug
- 4465411b - Fix last spec failure
- 8631779b - Merge branch 'bvl-fix-project-ci-status-cache' into 'master'
- fd16c892 - Merge branch 'karma-failure-fix' into 'master'
- d4058995 - Fix rake test to import Github repositories
- 31437028 - Merge branch 'optimise-builds' into 'master'
- 682748e8 - Add ref and active to import/export config
- 06e7de40 - Review changes
- f18e05b9 - Remove wrong user email from CI variables example output
- 9bf3dfd7 - Merge branch 'docs/ci-variables-remove-my-email' into 'master'
- 5d444915 - Merge branch 'fix-github-import-rake-task' into 'master'
- a5badd40 - Update todos.md
- 3ded903d - Merge branch 'dosuken123/gitlab-ce-2989-run-cicd-pipelines-on-a-schedule-idea1-b…
- ace833b3 - Add indication for closed or merged issuables in GFM
- 4bdbccfc - Remove Vue from main bundle and disable production warnings
- d37f1f1c - Merge branch '30151-fix-vue-production-warnings' into 'master'
- 8e8900e5 - Revert yarn.lock file changes
- 501d4032 - Rever yarn.lock changes
- 6410016e - upgrade webpack to v2.3.3 to resolve sourcemap issues
- 8b98ca50 - Merge branch 'master' into new-resolvable-discussion
- a76ab4ae - upgrade webpack-dev-server to fix issues with SockJS causing odd reload behavior in firefox
- 174dca9d - add CHANGELOG.md entry for !10522 (merged)
- 6ca6ca89 - Merge branch 'test-failure-fix' into 'master'
- 1ebfcf90 - Revert yarn.lock changes
- 41f79250 - Wait for AJAX requests to complete so they don't blow up if they are only handle…
- 667fa9af - Put back usernames in activity and profile feed
- c025a0eb - Update MR title change icon
- 63cbf905 - Merge branch 'title-change-icon' into 'master'
- 57392fcc - Give explicit height to SVG icons for Safari
- c8cea68f - alfredo review changes
- a5792a86 - Don't show Copy contents button on Blame page
- 60ec9c8d - Merge branch '30588-fix-javascript-sourcemaps-w-chrome-breakpoints' into 'master'
- 33a050d3 - Merge branch 'feature/add-rake-task-prints-storage-config-in-toml' into 'master'
- ae65817b - Actually include WaitForAjax!
- 7759049b - Merge branch 'activity-feed-user-name' into 'master'
- 68a839c2 - Merge branch 'adam-finish-5993-closed-issuable' into 'master'
- 4caa9b63 - Rename displaying_blame to blame
- e2129c91 - Merge branch 'dm-wait-for-pipeline' into 'master'
- e5a11687 - Merge branch 'safari-svg-bug' into 'master'
- a4eeb96d - Merge branch 'clarify-mr-with-someone' into 'master'
- ea4cf005 - Remove limited container on file view
- 86a2fb2f - Update rubocop-rspec 1.12.0 -> 1.15.0
- 6576a6ce - Enable RSpec/DescribeSymbol; update .rubocop_todo.yml
- 7d3f37b0 - Merge branch 'dm-remove-copy-link-on-blame-page' into 'master'
- 130a1e86 - Fix specs
- f058b52b - Merge branch 'master' into new-resolvable-discussion
- 40407764 - Merge branch 'rs-rubocop-rspec' into 'master'
- 3d1cade1 - Merge branch 'new-resolvable-discussion' into 'master'
- 82fad17a - Add information about namespace encoding to API docs
- 5422554b - Mention URL path encoding to all API docs
- 11aff97d - Remove the User#is_admin? method
- d0beb755 - Add a name field to the group edit form
- 8265fe39 - Merge branch 'add-field-for-group-name' into 'master'
- 5e1a802b - Merge branch 'remove_is_admin' into 'master'
- 3a33a795 - Fix email not being sent after project export
- 6c547e31 - add vue-loader dependencies and basic config
- 0ca62a68 - clean up webpack config
- 0329d793 - update Vue to match vue-template-compiler
- 90971841 - convert pipeline empty state to vue template
- 4cc88f59 - convert pipeline error state to vue template
- 04f29d6e - convert pipeline async_button component to vue template
- 8050d835 - add eslint support to vue files
- 24af43bf - add CHANGELOG.md entry for !10517 (merged)
- 731276c3 - fix closing tags of async_button component
- 02f1599d - add license approvals for vue-loader
- 01adf920 - Merge branch 'refactor-behaviors' into 'master'
- ad27f204 - Periodically clean up temporary upload files to recover storage space
- 9f8ae20f - Fix redundant cache expiration in Repository
- c98add15 - Merge branch 'clean_carrierwave_tempfiles' into 'master'
- f8dd1195 - Test all enabled routes in ETag caching middleware and fix pipeline routes
- 171eab81 - Add spec for schema.rb
- 2dab7245 - Added back in the CI status favicon
- b472f999 - Fix wrong copy edits for URL-encoded substitutions in API docs
- fede01fb - Fixed karma
- 94668490 - Merge branch '30676-project-export-email' into 'master'
- ce6a48cb - Merge branch 'test-all-etag-routes' into 'master'
- 3fa89854 - Reuse "merge_requests_for_nodes" in "MergeRequestParser"
- 9a8ea266 - Merge branch 'spec_for_schema' into 'master'
- f328a775 - Remove broken link
- 6536e3d5 - Add URL encoding link to issues API
- 6c7b4791 - Merge branch 'alkuzad/gitlab-ce-namespaces_encoding_docs' into 'master'
- 481f07e7 - Merge branch 'file-view-container' into 'master'
- 9c576cc7 - Merge branch 'ci-favicon-back-in' into 'master'
- 05aa038c - Add a Gitlab::Git::Env to store Git-specific env thread-safely
- 710cd82c - Set Git-specific env in /api/internal/allowed
- cb20cfa2 - Retrieve Git-specific env in Gitlab::Git::Repository#rugged
- ae88355b - Retrieve Git-specific env in Gitlab::Git::RevList and add a new #new_refs method
-
3de11e1a - Don't pass
envanymore to GitAccess, ChangeAccess, and ForcePush - dbbf4818 - Merge branch 'todos-docs-update' into 'master'
- 075bdd6c - Document how polling interval is used
- 76cec340 - Merge branch '25274-gitlab_flow-md-broken-download-link-in-resources' into 'master'
- 3fda6f52 - Merge branch 'merge-request-parser-merge-requests-for-nodes' into 'master'
- 1f0cdabd - Update CHANGELOG.md for 9.0.5
- d38eae3b - Merge branch 'add-vue-loader' into 'master'
- 008e135f - Merge branch 'document-polling-interval' into 'master'
- 0b5a8a34 - Merge branch 'backport-ee-1525' into 'master'
- 3812abfa - watch node_modules for changes when a module is missing
- dd24066f - add license approval for ansi-html
- cb2c762d - use nodemon to watch for changes to webpack config and restart the dev server when necessary
- 6ce9b71c - add license approbals for nodemon dependencies
- fa120a06 - add CHANGELOG.md entry for !10581 (merged)
- 9c2b0f54 - Merge branch '1595-ee-backport-environments-tests' into 'master'
- 7ae3001d - Merge branch 'dewet-do-disclaimer' into 'master'
- 520ed078 - Merge branch 'rs-fix-doc-anchor-link' into 'master'
- fb8a12c8 - Don't show 'Copy content' button on text files that are not rendered as text
- 84da388d - Merge branch 'dm-remove-copy-link-on-svgs' into 'master'
- 100f4370 - Merge branch 'fix_cache_expiration_in_repository' into 'master'
- 19dd138c - Merge branch '30678-improve-dev-server-process' into 'master'
-
d0df9bf7 - Add
eslint-plugin-promiseto lint Promises - ea5fa241 - Enable eslint-plugin-promise
-
c9093415 - ESLint: Fix
promise/catch-or-returnoffences -
ee0a0831 - ESLint: Disable
promise/catch-or-return, addfailfor jQuery Ajax -
5488685e - ESLint: Disable
promise/catch-or-returnwhere not applicable
Toggle commit listassigned to @ClemMakesApps
assigned to @kushalpandya
mentioned in issue #30821 (moved)
-
@ClemMakesApps Done with the changes, can you review and merge? note that this MR merges changes to main MR https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9969.
assigned to @ClemMakesApps
LGTM. Thanks @kushalpandya
-
Thanks @ClemMakesApps, I've added you as approver for the MR, please approve and merge, I'll then update main MR, let's try to get this in early.
mentioned in commit 8efe67aa
mentioned in issue gitlab#8816
mentioned in issue gitlab#9247
Please register or sign in to reply