Skip to content
Snippets Groups Projects

Support PlantUML blocks in reStructuredText

All threads resolved!

What does this MR do?

Adds support for PlantUML blocks in the following format:

.. plantuml::

   Bob -> Alice: hello
   Alice -> Bob: Go Away

Based on the Markdown approach in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8588, the real work is done by Banzai::Filter::PlantumlFilter.

This development is sponsored by Siemens (/cc @bufferoverflow)

Are there points in the code the reviewer needs to double check?

  • We could consider using uml:: instead of plantuml:: to match sphinxcontrib-plantuml, I decided to use the latter since we don't support the additional options from sphinxcontrib
  • All <pre> tags now also contain a <code> tag, this looks the same on GitLab but might break layout if this gem is used outside of it
Edited by Gabriel Mazetto

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • username-removed-423116 resolved all discussions

    resolved all discussions

  • Gabriel Mazetto changed milestone to %10.1

    changed milestone to %10.1

  • assigned to @brodock

  • username-removed-423116 resolved all discussions

    resolved all discussions

  • @smcgivern can you review this as well?

  • Gabriel Mazetto changed title from Support PlantUML blocks to Support PlantUML blocks in reStructuredText

    changed title from Support PlantUML blocks to Support PlantUML blocks in reStructuredText

  • @smcgivern is out for the week. @DouweM can you take this one please?

  • assigned to @DouweM

  • merged

  • @toupeira Merged and released as v1.6.2! Can you create an MR to pull this into gitlab-ce?

  • Please register or sign in to reply
    Loading