Skip to content
Snippets Groups Projects

Rework the artifacts proxy to operate within Pages group domains

Merged Nick Thomas requested to merge nick.thomas/gitlab-pages:83-artifact-proxy-changes into master
All threads resolved!

When -artifacts-server is enabled, we now proxy requests with paths of the following form to the GitLab API:

group.gitlab.io/-/subgroup/project/-/jobs/1/artifacts/index.html

Closes #83 (closed)

Edited by Nick Thomas

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Maintainer

    @ayufan there's another possibility for the path, which I hadn't considered before.

    • group.gitlab.io/-/subgroup/project/-/jobs/1/artifacts/index.html
    • group.gitlab.io/-/project/-/jobs/1/artifacts/index.html

    It doesn't really have any advantages over the current scheme except that it allows the subgroups and project to go together, instead of them being separated as they are now (e.g., group.gitlab.io/subgroup/-/project/jobs/1/artifacts/index.html

    Let me know if you'd like this to change.

    Edited by Nick Thomas
  • Nick Thomas resolved all discussions

    resolved all discussions

  • Author Maintainer

    If we're to keep the existing scheme, maybe we should make the URL even longer:

    mytoplevelgroup.gitlab.io/mysubgroup/-/projects/myproject/jobs/1/artifacts/index.html

    Otherwise, we're storing up problems for when we want to add more functionality of this nature after the /-/.

    Edited by Nick Thomas
  • mentioned in issue #83 (closed)

  • Nick Thomas changed the description

    changed the description

  • Kamil Trzcińśki
  • Generally, there's quite an amount of changes. I just have two questions more, than something to complain. Please let me know what do you think @nick.thomas

  • Author Maintainer

    @ayufan OK, addressed and ready for review again.

  • Kamil Trzcińśki resolved all discussions

    resolved all discussions

  • Please register or sign in to reply
    Loading