Fix encoded characters in api requests, as well as missing error pages

All requests previously would get forwarded to gitlab-workhorse, including requests to error pages and existing files which Apache itself could serve. The redirect rule now checks for existing files before forwarding to gitlab-workhorse. This closes #43 (closed).

As discussed in https://gitlab.com/gitlab-org/gitlab-recipes/commit/fe1bb890a60a3bfcb8a7b28b3aca2f83e08ef98b#note_4332704 API requests need percent encoded characters. API requests are now handled by a different redirect rule which doesn't escape these characters.

If there are further URLs which need to contain percent encoded characters please let me know.

@Zenti awesome! What about https://gitlab.com/gitlab-org/gitlab-recipes/issues/36, do you think this is relevant?

Thanks!

To be honest, I'm not quite sure. The issue you linked clearly is about URL encoding, so the general problem of how to pass such encoded URLs is the same.

However, the problem I addressed is about Apache escaping the percent sign, so translating %2F into %252F. The linked issue in contrast deals with Apache actually decoding such characters, so translating %252F into %2F. These are exactly the opposite directions.

Maybe Apache does provide a No Decode flag for us to use.

A NoDecode flag could probably solve the issue you linked. But I do not know yet whether Apache offers that flag.

Fair enough, I'll go ahead and merge this since it fixes the API issue which is important. Thanks again!

Status changed to merged

mentioned in issue #43 (closed)