Runner tries to check if gitlab/gitlab-runner-helper is in among allowed images

Summary

The runner fails because gitlab/gitlab-runner-helper isn't among the allowed images.

Steps to reproduce

Setup a runner with a docker executor. Set allowed-images = ['debian:*'] (I believe specifics don't matter). Trigger a build

Actual behavior

Here's what I in the build logs:

Running with gitlab-ci-multi-runner 9.4.0 (ef0b1a6)
  on test-key-runner (<redacted>)
Using Docker executor with image akhmerov/nikola ...

ERROR: The sha256:424eec744f91ffda64d28751b98d151a5986744b95c6dade79dcb2c299d93636 is not present on list of allowed images
- akhmerov/nikola

Please check runner's configuration: http://doc.gitlab.com/ci/docker/using_docker_images.html#overwrite-image-and-services
ERROR: Preparation failed: invalid image
Will be retried in 3s ...
Using Docker executor with image akhmerov/nikola ...

The sha is the current version of gitlab/gitlab-runner-helper, and it isn't mentioned anywhere in the build process.

Adding the sha manually to the list of allowed images functions as a workaround.

Expected behavior

I expect that the runner helper image would be always allowed for use by the gitlab runner itself (but not as an environment where the users run their processes).

Environment description

ubuntu 14.04, gitlab-ce 9.4.0, gitlab-runner 9.4.0, docker 17.05.0-ce.

Used GitLab Runner version

Version:      9.4.0
Git revision: ef0b1a6
Git branch:   
GO version:   go1.8.3
Built:        Sat, 22 Jul 2017 08:21:04 +0000
OS/Arch:      linux/amd64

Sounds like issue https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/issues/175 resurfacing. I'm also affected. (gitlab-runner 9.4.0, gitlab 9.3.7)

I could not make my environment work by manually whitelisting individual hashes, due to them being different on various hosts. In the meantime I downgraded the runner package to 9.3.0 which works for me.

Thanks for the report!

added regression label

changed milestone to %9.4

mentioned in merge request !635 (merged)

closed via merge request !635 (merged)

Thanks for a quick fix! Do you plan a bugfix release?

@anton-akhmerov Yes. It's on the way :)

And it should be available now :)