Skip to content

Use a native vendor/ directory with godep

Nick Thomas requested to merge nick.thomas/gitlab-ci-multi-runner:godep-native-vendor into master

This MR was created by following these instructions: https://github.com/tools/godep#migrating-to-vendor

In short -

  • Create a pristine GOPATH
  • godep restore
  • rm -rf Godeps vendor
  • godep save -t ./...

This causes a few issues with the Makefile (as go list ./... now includes packages in vendor/), which the second commit solves.

No package versions are changed, but the listing in Godeps/Godeps.jsonchanges quite a bit. This churn is appearing in other MRs (like !30 (merged)), and is caused by:

  • changes to upstream repositories (tag changes)
  • gitlab-ci-multi-runner (removed dependencies)
  • Godep itself handling dependencies differently (e.g., the entries for github.com/fsouza/go-dockerclient/external/*)

Overall, the MR should be a no-op for the generated gitlab-ci-multi-runner binary. Future MRs based on top of this one will have less trouble managing their dependencies and their diffs should be smaller, though.

Merge request reports