[WIP] Feature/licenses check
What does this MR do?
Adds a tests step that checks compatibility of licenses in vendored packages.
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Branch has no merge conflicts with master
(if you do - rebase it please)
What are the relevant issue numbers?
Resolves #1608
Merge request reports
Activity
Why not use LicenseFinder as we do with CE?
mentioned in issue #1608
Hmm... I first searched for some tool for license checking in GO applications, then found the #1608 issue and the remembered about LicenseFinder
But I see two advantages of using this instead of LicenseFinder:
-
LicenseFinder is a ruby tool. It needs ruby in test environment. Why to add ruby (and all needed dependencies) when we can use a "native go" tool which has the environment ready
-
I see that LicenseFinder supports:
- Godep
- Go workspace (via a .envrc file)
- Go submodules
while I'm thinking about migrating from Godep to Glide. I don't know if LicenseFinder will work with dependencies managed by Glide.
-
@tmaczukin I used govendor in my go playgrounds.
It uses the go 1.5+ vendor folder and works pretty well. How it looks like its also supported by licensefinder
Milestone changed to %Backlog
Added 127 commits:
- f9983a99...0856546e - 126 commits from branch
master
- 516378eb - Add license check step to tests
- f9983a99...0856546e - 126 commits from branch
Added 25 commits:
- 516378eb...b8a30269 - 24 commits from branch
master
- a71aed1f - Add license check step to tests
- 516378eb...b8a30269 - 24 commits from branch
added 398 commits
- a71aed1f...ca7707b0 - 397 commits from branch
master
- 2d076ca2 - Add license check step to tests
- a71aed1f...ca7707b0 - 397 commits from branch