Skip to content

change docker runner to understand auth put in an image name.

username-removed-633258 requested to merge eyecreate/gitlab-ci-multi-runner:feature/docker-registry-auth into master

What does this MR do?

Adds in code to the auth handlers in docker to support image names to have http basic auth style syntax. This allow 3rd party and gitlab private registries that don't or can't log in on the machine itself to specify in the yaml itself how to access a private docker image.

Why was this MR needed?

Private registry support is missing in the docker executor of the runner. This allows for using runners that want to run against private images in a better way.

Are there points in the code the reviewer needs to double check?

Edge cases are the best way to find code flaws in code like this.

Does this MR meet the acceptance criteria?

  • CHANGELOG entry added
  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/issues/1473

Merge request reports