Fix range mismatch handling error while patch tracing
Loading
Do not update/delete: Banner broadcast message test data
Do not update/delete: Notification broadcast message test data
This MR adds some tests for trace patching and fix a bug that finishes with a panic
while handling a range mismatch in some situations.
We've had a situation where the same build was triggered second time by GItLab. In GitLab the build trace was 17041 bytes long while the repeated build trace was only 66 bytes long. We've had a RangeMismatch
response, so the offset was updated (to 17041) and client.PatchTrace
was repeated, at it was planned. Unfortunately the tracePatch
struct was not resistant to a situation when the offset is set to a value bigger than trace's length. This MR fixes such situation, adds a test to guard us from regressions and adds some other tests for trace patching feature.
master
(if you do - rebase it please)/cc @ayufan