Skip to content
Snippets Groups Projects

Add param for separate RootCA

Closed username-removed-20268 requested to merge iavael/gitlab-ci-multi-runner:master into master

Added -x/--rootca param to define non-system rootca store. It may be needed, fo example if we have internal ca, which we don't want to install systemwide for security reasons or, in my case, if we have selfsigned certificate on gitlab-ci server (we pass this certificate as rootca store and so workaround bugs like #150 (closed) and #71 (closed))

Since UnregisterRunner is totally broken (#39 (closed), it ignores cli options and tries to read config before loading it, so URL and Token params are always empty), I didn't touch it, because fixing it is unrelated to this MR and there are several ways to do this.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • username-removed-20268 Title changed from Add param for separate RootCA and Fix building runner on FreeBSD to [WIP] Add param for separate RootCA and Fix building runner on FreeBSD

    Title changed from Add param for separate RootCA and Fix building runner on FreeBSD to [WIP] Add param for separate RootCA and Fix building runner on FreeBSD

  • Added 1 commit:

    • 9bea220d - Add stub param for DeleteRunner
  • username-removed-20268 Title changed from [WIP] Add param for separate RootCA and Fix building runner on FreeBSD to Add param for separate RootCA and Fix building runner on FreeBSD

    Title changed from [WIP] Add param for separate RootCA and Fix building runner on FreeBSD to Add param for separate RootCA and Fix building runner on FreeBSD

  • Can you describe why do we need RootCA?

  • Can you add separate MR that fixes just FreeBSD?

  • Since UnregisterRunner is totally broken

    Can you describe it?

  • Added 2 commits:

    • 9a63d9c6 - Add param to specify RootCA
    • 771d0c6e - Add stub param for DeleteRunner
  • username-removed-20268 Title changed from Add param for separate RootCA and Fix building runner on FreeBSD to Add param for separate RootCA

    Title changed from Add param for separate RootCA and Fix building runner on FreeBSD to Add param for separate RootCA

  • Changed MR description accordong to your requests

  • I'll look into it and integrate it into 0.6.0.

    Thanks

  • Kamil Trzcińśki Milestone changed to v0.6.0

    Milestone changed to v0.6.0

  • @iavael seems you forgot add -x/--rootca to gitlab-ci-multi-runner --help output

  • @iavael Please enter the gitlab-ci tags for this runner (comma separated): can't left blank in your fork

    Edited by username-removed-43784
  • Added 28 commits:

    • 771d0c6e...4c26bc55 - 27 commits from branch gitlab-org:master
    • 571ac75d - Merge remote-tracking branch 'upstream/master'
  • @guria

    seems you forgot add -x/--rootca to gitlab-ci-multi-runner --help output

    --help output is generated automatically, and i see this param under '-t, --token' for register, unregister and run-single commands. Mb you built runner from wrong repo?

    can't left blank in your fork

    Merged changes from upstream's master

    Edited by username-removed-20268
  • More complete solution was merged: https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/blob/master/docs/configuration/tls-self-signed.md

    Currently is in Bleeding Edge release, but it will be live in 0.7.0.

  • Kamil Trzcińśki Status changed to closed

    Status changed to closed

  • Please register or sign in to reply
    Loading