Skip to content

Refactoring common.Config

username-removed-87366 requested to merge remohammadi/gitlab-ci-multi-runner:refactor/save-config-clear-usage into master

What does this MR do?

Refactors common.Config to limit the usage of SaveConfig()

Why was this MR needed?

Some of the current deployment methods, like kubernetes for example, expect the runner not to modify the configuration file while running. This assumption is not guaranteed by the current structure of code. To make it clear, and to be sure that the future developers won't modify the config file in a way it wasn't designed for, it's better to unexpose the SaveConfig() method, and have special methods for every case there is a need to update the config file.

Are there points in the code the reviewer needs to double check?

  • Is it ok to pass nil instead of a dummy Config to Build.Run in RunSingleCommand.processBuild?

Does this MR meet the acceptance criteria?

  • Documentation created/updated (No behavioural change)
  • Tests
    • Added for this feature/bug (There wasn't any easy starting point to write test code for the modified files)
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

  • The #1688 was the initial point

Merge request reports