Skip to content

Handle received 'failed' build state while patching the trace

Tomasz Maczukin requested to merge fix/handle-failed-state-while-patching-trace into master

What does this MR do?

Fixes handling of builds that were marked as "failed" by GitLab. Please read gitlab-org/gitlab-ce#22087 for reference.

Why was this MR needed?

After adding the trace patching feature we didn't handled properly the situation when build was marked as "failed" on GitLab's side. This MR fixes this.

Are there points in the code the reviewer needs to double check?

Construction of network/patch_response.go.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Related to gitlab-org/gitlab-ce#22087

Merge request reports