What does this MR do?
- By default, we keep current behavior, URLs have the form
sharedflag is enabled, the runner segment is removed from the URL:
- In any case, we could add a
Pathprefix to that URL:
Why was this MR needed?
Some users have problems when using autoscaling, because there's no way to remove runner token in the URL or add a prefix with the path. This change will enable both things preserving existing functionality.
Are there points in the code the reviewer needs to double check?
Path allows spaces and other non-compatible URL characters that might cause problems or security issues. I've assumed we don't have to solve this here, given that
ServerAddress for instance might introduce same problems - but it wouldn't harm to point that out in case we do that in the future.
cache_extractor.go may be a good place to check for malformed URLs.
Does this MR meet the acceptance criteria?
Added for this feature/bug
All builds are passing
Branch has no merge conflicts with
master(if you do - rebase it please)
What are the relevant issue numbers?
Resolves #1897 (closed)