Skip to content

Fix race in helpers/prometheus/log_hook.go: Fire() method

Tomasz Maczukin requested to merge fix/race-on-error-metric-collector into master

What does this MR do?

Fixes races that can occur with concurrent calls to Fire() in helpers/prometheus/log_hook.go.

Why was this MR needed?

https://gitlab.com/gitlab-com/infrastructure/issues/1079#note_22260206

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Merge request reports