Docker: Allow to configure shared memory size

What does this MR do?

Allow to set shared memory size for docker images.

Why was this MR needed?

Docker by default uses a shared memory size of 64m. Some images benefit from a bigger shared memory size, though. For example the docker selenium images recommend to mount shared memory space to fix crashes due to too low shared memory size. With this MR, the shared memory size can be increased with a config option.

Are there points in the code the reviewer needs to double check?

This is based on top of !301 (merged) because the current used (outdated) dockerclient does not support the ShmSize, so !301 (merged) has to be merged in first. Changes on top of that are really small - just passing through the new config option.

Does this MR meet the acceptance criteria?

• Documentation created/updated
• Tests
  • Added for this feature/bug
  • All builds are passing
• Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Fixes #1913 (closed)

changed title from Shm size to Docker: Allow to configure shared memory size

not sure about the failing tests, because !301 (merged) is green and this looks like it has nothing to do with the config changes on top.

mentioned in issue #1913 (closed)

changed milestone to %v1.11

added executordocker improvement labels

Thanks @doits. I will wait with the review until !301 (merged) is merged so it'll be clear what this MR introduces. I hope this will be done at the beginning of next week :)

changed milestone to %v9.0

added 18 commits

• 2fc35e21...b4c159dc - 17 commits from branch gitlab-org:master
• d9ec0c0c - Allow to specify shared memory size for docker containers and services

Compare with previous version

added 66 commits

• d9ec0c0c...f26c698f - 65 commits from branch gitlab-org:master
• eee481d6 - Allow to specify shared memory size for docker containers and services

Compare with previous version

rebased this on master, and looks like test went through, too

marked the task Branch has no merge conflicts with master (if you do - rebase it please) as completed

added 11 commits

• eee481d6...ca7707b0 - 10 commits from branch gitlab-org:master
• a382e948 - Allow to specify shared memory size for docker containers and services

Compare with previous version

Just a small ping: Anything to change here before this can be merged?

@doits Need to test this. And since 22th is soon, I'm moving this to %v9.1 and I'll get back to this just after release :)

changed milestone to %v9.1

Will this enable us to configure shared memory in the Kubernetes executor too?

Just rebased it on master. Hope this will make it into 9.1.

Looks good :)

Thanks @doits!

approved this merge request

merged

mentioned in merge request !553 (merged)