Skip to content

Use HTTP status code constants from net/http library

username-removed-271606 requested to merge dohnto/gitlab-ci-multi-runner:td-http-status-constants into master

What does this MR do?

Change hard-coded HTTP status variables with predefined HTTP status constants from net/http library.

Why was this MR needed?

Not really needed.

Are there points in the code the reviewer needs to double check?

Not sure why there was 408, is it correct? Seems that 405 is more appropriate: https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/blob/a4f18c9918e8e970dfb9cb734ba102494f1d8c43/commands/helpers/cache_archiver_test.go#L56

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

#1579

Edited by username-removed-271606

Merge request reports