Skip to content

Master

This is a general Merge Request template. Consider to choose a template from the list above if it will match your case more.

What does this MR do?

Fixes a bug whereby updates from the gitlab-runner repo overwrites any local config set up by gitlab-runner install, and continues to return to the default user.

Why was this MR needed?

The presented code bypasses the problem by storing any previous installation configuration at install time.

Are there points in the code the reviewer needs to double check?

Whilst this can be done in this fashion, it would be better to extend the toml config file to support these fields.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

#2422

Merge request reports