Skip to content
Snippets Groups Projects

Improve kubernetes volumes support

Merged Tomasz Maczukin requested to merge improve-kubernetes-volumes-support into master
All threads resolved!

What does this MR do?

Adds some improvements to recently added Kubernetes Volumes support.

Why was this MR needed?

With !516 (merged) (released with v9.3.0) and !606 (merged) (planned for v9.4.0) we've added support for volumes configuration for Kubernetes executor. This MR adds some improvements:

  • selecting keys from configMap that should be added with a volume,
  • selecting keys from secret that should be added with a volume,
  • configuring a host path - different from mount_path - that should be mounted inside of container (in current implementation hostPath needed to be the same path that was used inside of container, so it was impossible to mount host's /path/one as container's /path/two).

This MR improves also documentation related to Kubernetes volumes support.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Fixes #2573 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tomasz Maczukin mentioned in merge request !516 (merged)

    mentioned in merge request !516 (merged)

  • I'll take a look tomorrow :)

  • Kamil Trzcińśki approved this merge request

    approved this merge request

  • Kamil Trzcińśki resolved all discussions

    resolved all discussions

  • Achilleas Pipinellis added Documentation and removed ~60197 labels

    added Documentation and removed ~60197 labels

  • Please register or sign in to reply
    Loading