Skip to content

Remove confusing compatibility check

Tomasz Maczukin requested to merge remove-confusing-compatibility-check into master

What does this MR do?

Removes a confusing compatibility check from ./network/.

Why was this MR needed?

The check was added after we've released GitLab Runner 9.0 which required GitLab >= 9.0 to work. From the beginning it was a nasty hack and was designed only to suggest user that he should check if used GitLab Runner and GitLab versions are compatible.

At this moment we know that this check was not fully reliable and it was confusing users. Also most of users know already about the versions compatibility requirements. We should then remove this check and in the future think about a more generic "version negotiation" protocol.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Merge request reports