Skip to content
Snippets Groups Projects

Add network-aliases for services containers

Open Tomasz Maczukin requested to merge add-network-alias-of-services into master
1 unresolved thread

What does this MR do?

Adds --network-alias usage for services configuration.

Why was this MR needed?

This is a partial solution for problem described at #2699.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

References #2699

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
554 555 return
555 556 }
556 557
557 func (s *executor) createService(serviceIndex int, service, version, image string, serviceDefinition common.Image) (*types.Container, error) {
558 func (s *executor) createService(serviceIndex int, service, version, image string, serviceDefinition common.Image, aliases []string) (*types.Container, error) {
Please register or sign in to reply
Loading