Skip to content
Snippets Groups Projects

Use full repository path instead of extracting name

Merged Use full repository path instead of extracting name
dz-support-nested-namespaces into master
1 unresolved thread
Merged username-removed-444 requested to merge dz-support-nested-namespaces into master
1 unresolved thread

In order to implement nested groups https://gitlab.com/gitlab-org/gitlab-ce/issues/2772 we can not rely on old path with one slash that split namespace and project name like namespace/project.git. Now it can be both namespace/project.git and namespace/namespace/namespace/project.git. Because of that it makes no sense to extract part of full path. Instead we just pass path to API without change and let rails application do parsing/extraction.

Signed-off-by: Dmitriy Zaporozhets dmitriy.zaporozhets@gmail.com

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
lib/gitlab_net.rb
118 118
119 119 protected
120 120
121 def project_name(repo)
122 project_name = repo.gsub("'", "")
123 project_name = project_name.gsub(/\.git\Z/, "")
124 project_name.gsub(/\A\//, "")
121 def sanitize_path(repo)
122 repo.gsub("'", "")
  • username-removed-444
    username-removed-444 @dzaporozhets ·
    Author Owner

    @smcgivern can you please review while I am waiting for CI?

  • username-removed-443319
    username-removed-443319 @smcgivern ·
    Contributor

    @dzaporozhets I don't see any issues with this, I didn't beat CI though :smile:

  • username-removed-444
    username-removed-444 @dzaporozhets ·
    Author Owner

    Requires https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7148 to make GitLab work with this change

  • username-removed-444 Status changed to merged

    Status changed to merged

  • username-removed-444 Mentioned in commit 0f8a3cbb

    Mentioned in commit 0f8a3cbb

    • Please register or sign in to reply