Vendor redis_rb from Rubygems, not GitHub

Also just include the entire gem. Space used is negligible and this way we don't have to think about what to leave in/out.

assigned to @stanhu

assigned to @jacobvosmaer-gitlab

added 1 commit

• 3fe9cea0 - Vendor redis_rb from Rubygems, not GitHub

Compare with previous version

This script replaces the Makefile.

Is there a way of easy way of knowing which version is actually vendored?

Aside: I somehow get the funny feeling we are re-inventing Bundler. :)

Currently, in this MR, this information is in lib/vendor/redis/redis.gemspec which reads lib/vendor/redis/lib/redis/version.rb.

One thing we could do is to make the vendor directory include the version lib/vendor/redis-3.3.0 and then that actual directory path is specified in lib/gitlab_redis.rb (in the $:.unshift line).

Or we could put the vendor-gem script in the root and instead of making it a general purpose script (that takes the gem, version etc. as args) have it vendor a fixed list of gems.

VENDOR_GEMS = {
  'redis' => '3.3.0'
}

VENDOR_GEMS.each do |gem, version|
  fetch_gem(gem, version)
end

Yes, it does seem like we are reinventing Bundler. I wonder at what point we decide to try to make that work. :)

I'm fine with the latter method.

assigned to @stanhu

Doing this because it will make it easier to vendor excon https://gitlab.com/gitlab-org/gitlab-shell/issues/72#note_20777671

assigned to @jacobvosmaer-gitlab

BTW #72 (closed) got resolved without having to vendor excon so there no direct need for this change. But I think this MR still clarifies the situation a bit.

Closing because it is stale, and because we want to get rid of the Redis dependency in gitlab-shell https://gitlab.com/gitlab-org/gitlab-shell/issues/77.

closed