Skip to content
Snippets Groups Projects

Add POST notification to gitaly on post-receive

Closed username-removed-367626 requested to merge gitaly-post-receive into master
3 unresolved threads

This is the gitlab-shell part of https://gitlab.com/gitlab-org/gitaly/issues/37

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @eReGeBe to complete gitaly#37 (closed) we need to also have the endpoint. But we can merge the two changes independently.

  • Next steps for this discussed in meeting:

  • Sounds good. Also: make sure there is a short-ish timeout on this request, maybe 5 seconds.

  • added 4 commits

    • 2e1299cc - Separate HTTP logic from GitlabNet
    • c7a788cc - Add POST notification to gitaly on post-receive
    • 097aeb2c - Correctly encode post-receive notification parameters
    • 945b7245 - Be more permissive with Gitaly's connections (for the moment)

    Compare with previous version

  • mentioned in merge request gitaly!36 (closed)

  • @jacobvosmaer-gitlab @eReGeBe Should we consider moving GitalyClient to a separate gem in order to be reusable between gitlab-ce (for stuff like https://gitlab.com/gitlab-org/gitaly/issues/48) and gitlab-shell?

  • added 2 commits

    • d762a81c - Add POST notification to gitaly on post-receive
    • 3be939ac - Be more permissive with Gitaly's connections (for the moment)

    Compare with previous version

  • added 2 commits

    • 3c9797f0 - Add POST notification to gitaly on post-receive
    • 720201c3 - Be more permissive with Gitaly's connections (for the moment)

    Compare with previous version

  • username-removed-367626 unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Ready for review. Pair with https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8440 for the internal API endpoint.

  • Oops, forgot to reassign :) also, it should be paired with gitlab-ce!8618 now.

  • added 2 commits

    • 730ebf83 - Add POST notification to gitaly on post-receive
    • 49a041e4 - Be more permissive with Gitaly's connections (for the moment)

    Compare with previous version

  • added Gitaly label

  • Please register or sign in to reply
    Loading