adds timeout option to push branches and respective test suite

Adds Timeout option to push_branches

Related to https://gitlab.com/gitlab-org/gitlab-ee/issues/1907

added 1 commit

• 94224c3e - adds timeout option to push branches and respective test suite

Compare with previous version

added 1 commit

• 078de5b2 - adds timeout option to push branches and respective test suite

Compare with previous version

assigned to @dbalexandre

@tiagonbotelho LGTM I left a minor comment.

assigned to @tiagonbotelho

added 1 commit

• c797f0b0 - adds timeout option to push branches and respective test suite

Compare with previous version

assigned to @DouweM

Don't for get to un-WIP if you think it's ready!

assigned to @tiagonbotelho

unmarked as a Work In Progress

assigned to @smcgivern

@tiagonbotelho thanks, can you add a CHANGELOG entry please?

changed milestone to %9.1

assigned to @tiagonbotelho

added 12 commits

• c797f0b0...6acaaa58 - 11 commits from branch master
• 655e2ba0 - adds timeout option to push branches and respective test suite

Compare with previous version

resolved all discussions

@smcgivern thanks for the comments! I will assign back now.

assigned to @smcgivern

resolved all discussions

resolved all discussions

added 1 commit

• 9e41159a - adds timeout option to push branches and respective test suite

Compare with previous version

enabled an automatic merge when the pipeline for 9e41159a succeeds

mentioned in commit 3d22504d

merged

resolved all discussions

@tiagonbotelho There are a lot of articles out there that explain why using Timeout.timeout is dangerous for this sort of thing:

• http://jvns.ca/blog/2015/11/27/why-rubys-timeout-is-dangerous-and-thread-dot-raise-is-terrifying/
• https://coderwall.com/p/1novga/ruby-timeouts-are-dangerous
• http://www.mikeperham.com/2015/05/08/timeout-rubys-most-dangerous-api/
• http://blog.headius.com/2008/02/rubys-threadraise-threadkill-timeoutrb.html
• https://gist.github.com/lpar/1032297

I wonder if we will run into these issues.

@stanhu @smcgivern also raised some concern about it. I was not aware of these problems at the time. Even if it is not a problem in this case if we ever touch this code in the future we might get into trouble so should we open a new issue and discuss some way of removing Timeout.timeout from both pull and push?

Yes, please do.

mentioned in issue #81