Skip to content
Snippets Groups Projects

Fetch repositories with --quiet option by default

Merged username-removed-283999 requested to merge add-quiet-option-to-fetch-command into master

What does this MR do?

This change will allow us to prevent deadlocks when dealing with extremely long outputs from git fetch. All the pipes (stdin, stdout, and stderr) have limited buffers, and when one fills up, everything is going to stop.

Are there points in the code the reviewer needs to double check?

I think this is the most boring solution, but we can try other approaches to read stdout and stderr simultaneously using thread or IO.select.

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/28183

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10273

@smcgivern @rspeicher @brodock

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading