Add hello-world Go executable and gitaly-proto 0.5.0
Add basic plumbing to have Go executables in gitlab-shell. We want to use this for Gitaly integration.
I have already included gitaly-proto via govendor even though it is not used yet.
Previous discussion in https://gitlab.com/gitlab-org/gitlab-shell/issues/80
Merge request reports
Activity
assigned to @jacobvosmaer-gitlab
- Resolved by Jacob Vosmaer (GitLab)
As a next step I wanted to add an external library and vendor it. My goal here is to get some of this annoying plumbing out of the way before someone else on the Gitaly team gets to do the interesting stuff.
But, now I am starting to see some of the consequences of this 'gitlab-shell has Go executables' idea.
it’s easy to make something that can compile for production installations
[6:02] but, development
[6:02] the current situation is that gitlab-shell sits in /gitlab-shell in GDK
[6:02] that does not make for good GOPATH integration
[6:02] the patter we follow so far is that each Go project in GDK has its own GOPATH
[6:02] e.g. gitlab-workhorse has GOPATH /gitlab-workhorse
[6:03] and the actual workhorse code sits in /gitlab-workhorse/src/gitlab.com/gitlab-org/gitlab-workhorse
[6:03] what makes me hesitate is the idea of inflicting this on gitlab-shell developers
I might be wrong, but I now get the feeling to make
gitlab-shell/go
not suck for Go developers, we have to makegitlab-shell
look like a Go project in GDK. Which sucks for Ruby devs. :(added 2 commits
- 7e243a3d - Better variable name
- 17ea90c2 - Test Go compilation during CI
mentioned in merge request gitlab-development-kit!282 (merged)
assigned to @brycepj
assigned to @rymai
Sorry @brycepj , I mis-clicked.
@jacobvosmaer-gitlab Works as advertised, thanks!
mentioned in commit 3986309c
mentioned in issue #85 (closed)