Skip to content
Snippets Groups Projects

Remove extraneous newlines in pre-receive hook

Open Stan Hu requested to merge remove-extra-newlines into master
  1. May 09, 2016
    • Stan Hu's avatar
      Remove extraneous newlines in pre-receive hook · 7a70b6d6
      Stan Hu authored
      Found while investigating slow performance in gitlab-org/gitlab-ce#17225
      
      We were adding a newline for every branch push because:
      
      1. GitlabAccess calls changes.lines, which keeps the newline (e.g. ['00000000 12345678 refs/heads/master\n'])
      2. GitlabNet calls changes.join("\n"), which adds another newline
      7a70b6d6
Loading