Added LFS support to SSH
Required changes to GitLab Shell include the actual handling of the git-lfs-authenticate command and the retrieval of the correct credentials.
Needed for gitlab-org/gitlab-ce!6043
Related to gitlab-org/gitlab-ce#3589
Note: gitlab-org/gitlab-ce!6043 needs to be merged before this one.
Merge request reports
Activity
Reassigned to @jacobvosmaer-gitlab
@jacobvosmaer-gitlab can you help me with a review here?
@patricio is @jacobvosmaer-gitlab the person to review this MR again?
Added 8 commits:
- 2d1fb2a8...c6d8af59 - 3 commits from branch
master - dbf374e1 - Added LFS support to SSH
- a64f174d - Refactored JSON header generation to its own class and added tests for it
-
c16f7323 - Added test for old Git LFS clients that submit an extra :oid argument to
git-lfs-authenticate - f53d09e1 - Refactored LFS auth logic to use its own API endpoint.
- e6e14fd8 - Style fixes and better tests.
Toggle commit list- 2d1fb2a8...c6d8af59 - 3 commits from branch
Added 1 commit:
- a070ae4a - Style fixes and better tests.
Reassigned to @DouweM
Reassigned to @patricio
Added 1 commit:
- 3c9ef9eb - Properly rescue from JSON parse.
Reassigned to @DouweM
@DouweM We also need this in order for LFS with SSH to work properly
Mentioned in commit 6c7f7b4d
@patricio Merged, and tagged v3.6.0! Can you update GITLAB_SHELL_VERSION?
@DouweM yes, the changelog item for this MR said 3.5.0 and the VERSION file was not updated here. Should I also create an MR here to update those?
