Clear environment variables before running hooks

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/20977

Changed title: Fix: Allow Git Hooks to be executed in another Ruby env when committing from the web UI → Clear environment variables before running hooks

mentioned in issue gitlab-workhorse#58 (closed)

We cannot do this here. gitlab-shell only uses stdlib

Where do we get Bundler env variables from?

from GitLab (https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/gitlab/git/hook.rb)

it's for "gitlab-web pushes" and I'm not sure where we pass it when push goes through the HTTP (workhorse)

We cannot do this here. gitlab-shell only uses stdlib

Hm, I tried this on omnibus installation and locally (for all three types of pushes)

As a general rule we don't use gems in gitlab-shell. I think this is because it can be unpredictable which Ruby runtime is invoked by #!/usr/bin/env ruby on installations from source.

In Omnibus we do not have this problem because we patch all gitlab-shell executables at build time: https://gitlab.com/gitlab-org/omnibus-gitlab/blob/master/config/templates/gitlab-shell/ruby_script_wrapper.erb

If we invoke from lib/gitlab/git/hook.rb in gitlab-rails we should do the Bundler.with_clean_env there.

@vsizov try head /opt/gitlab/embedded/service/gitlab-shell/bin/gitlab-shell to see what the patching does.

If we invoke from lib/gitlab/git/hook.rb in gitlab-rails we should do the Bundler.with_clean_env there.

HTTP pushes will be still broken

Why? gitlab-workhorse is launched without bundler

I will double check then, sound reasonable.

Yes, it works, you are right.

Yay

Closed in favor of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6344

@jacobvosmaer-gitlab Thanks for your time and help

Status changed to closed