Skip to content
Snippets Groups Projects

Prometheus metrics for multipart file extraction

Merged Jacob Vosmaer (GitLab) requested to merge multipart-metrics into master
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nick Thomas resolved all discussions

    resolved all discussions

  • 103
    104 file, err := os.OpenFile(path.Join(tempDir, filename), os.O_WRONLY|os.O_CREATE, 0600)
    105 if err != nil {
    106 return cleanup, fmt.Errorf("rewriteFormFilesFromMultipart: temp file: %v", err)
    107 }
    108 defer file.Close()
    109
    110 // Add file entry
    111 writer.WriteField(name+".path", file.Name())
    112 writer.WriteField(name+".name", filename)
    113
    114 written, err := io.Copy(file, p)
    115 if err != nil {
    116 return cleanup, fmt.Errorf("copy from multipart to tempfile: %v", err)
    117 }
    118 multipartFileUploadBytes.Add(float64(written))
  • Mostly :thumbsup:, just a couple of comments

  • Jacob Vosmaer (GitLab) mentioned in merge request !97 (merged)

    mentioned in merge request !97 (merged)

  • added 2 commits

    • c28f06f7 - Make metric description more precise
    • a43b2e94 - Put multipart rewrite work in functions

    Compare with previous version

  • I think this is good to go, we can always improve as suggested by @tmaczukin later.

  • merged

  • Nick Thomas mentioned in commit c1659c74

    mentioned in commit c1659c74

  • Please register or sign in to reply
    Loading