API improvements: buffering, metrics (!102) · Merge requests · GitLab.org / gitlab-workhorse · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Merged Jacob Vosmaer (GitLab) requested to merge buffer-api-failure-response into master 8 years ago

All threads resolved!

Following discussion in https://gitlab.com/gitlab-org/gitlab-workhorse/merge_requests/94

This closes a hole in our Unicorn response buffering. The responses should be small, hence buffering in-memory.

Activity

Jacob Vosmaer (GitLab) assigned to @nick.thomas 8 years ago

assigned to @nick.thomas
Jacob Vosmaer (GitLab) changed milestone to %8.15 8 years ago

changed milestone to %8.15
Jacob Vosmaer (GitLab) @jacobvosmaer-gitlab started a thread on an old version of the diff 8 years ago

Resolved 8 years ago by Nick Thomas
Last reply by Jacob Vosmaer (GitLab) 8 years ago

Nick Thomas @nick.thomas started a thread on an old version of the diff 8 years ago

Resolved 8 years ago by Nick Thomas

Nick Thomas assigned to @jacobvosmaer-gitlab 8 years ago

assigned to @jacobvosmaer-gitlab

Jacob Vosmaer (GitLab) added 1 commit 8 years ago

added 1 commit

8662789a - Limit API failure response buffer size

Compare with previous version

Jacob Vosmaer (GitLab) @jacobvosmaer-gitlab · 8 years ago

Author Contributor

Implemented a 32kB limit.

Jacob Vosmaer (GitLab) assigned to @nick.thomas 8 years ago

assigned to @nick.thomas

Nick Thomas resolved all discussions 8 years ago

resolved all discussions

Nick Thomas merged 8 years ago

merged

Nick Thomas mentioned in commit 8 years ago

mentioned in commit 2cb8fbac

Please register or sign in to reply