Forward {upload,receive}-pack requests to Gitaly

Closes gitaly#125 (closed)

mentioned in merge request gitaly!98 (merged)

added 2 commits

• 5849ff9a - Use a separate Gitaly socket for every test
• 8f169039 - Forward {upload,receive}-pack requests to Gitaly

Compare with previous version

assigned to @eReGeBe

unmarked as a Work In Progress

added 1 commit

• 48bb9121 - Forward {upload,receive}-pack requests to Gitaly

Compare with previous version

added 1 commit

• ff815506 - Forward {upload,receive}-pack requests to Gitaly

Compare with previous version

@ahmadsherif left some comments, mostly nitpicks.

assigned to @ahmadsherif

added 1 commit

• 565e38a6 - Forward {upload,receive}-pack requests to Gitaly

Compare with previous version

@eReGeBe Thanks, addressed them in the comments. Please take another look, if everything is OK then please pass it over to Jacob.

assigned to @eReGeBe

LGTM, on to @jacobvosmaer-gitlab

assigned to @jacobvosmaer-gitlab

assigned to @ahmadsherif

added 1 commit

• 1644990a - Forward {upload,receive}-pack requests to Gitaly

Compare with previous version

added 1 commit

• 38a677b8 - Forward {upload,receive}-pack requests to Gitaly

Compare with previous version

@jacobvosmaer-gitlab Comments addressed, please have another look.

assigned to @jacobvosmaer-gitlab

mentioned in issue #123 (closed)

assigned to @ahmadsherif

added 1 commit

• a7fb0ad2 - Forward {upload,receive}-pack requests to Gitaly

Compare with previous version

assigned to @jacobvosmaer-gitlab

My only issues are with the stdin/stdout variable names, and code reuse in the receive goroutine.

assigned to @ahmadsherif

added 1 commit

• 01fe1418 - Forward {upload,receive}-pack requests to Gitaly

Compare with previous version

assigned to @jacobvosmaer-gitlab

added 1 commit

• c5f18f23 - Forward {upload,receive}-pack requests to Gitaly

Compare with previous version

@ahmadsherif I will let Nick be the arbiter on the 'stdin'/'stdout' naming issue. Please assign to him for final review when ready.

assigned to @ahmadsherif

added 1 commit

• afefd7f4 - Forward {upload,receive}-pack requests to Gitaly

Compare with previous version

assigned to @nick.thomas

assigned to @ahmadsherif

Thanks @ahmadsherif, a few comments.

added 2 commits

• ead30886 - Rename testhelper.{AssertResponseHeader => AssertResponseWriterHeader}
• 45dc63b4 - Forward {upload,receive}-pack requests to Gitaly

Compare with previous version

Marking as WIP as we don't want to break the night builds (there's no server-side handling for such requests ATM).

marked as a Work In Progress

mentioned in issue gitaly#168 (closed)

mentioned in merge request !147 (merged)

@ahmadsherif there are some changes in !147 (merged) you will have to rebase on. See comments there.

added 12 commits

• 45dc63b4...2b604f62 - 9 commits from branch master
• b4acd08e - Use a separate Gitaly socket for every test
• c290616d - Rename testhelper.{AssertResponseHeader => AssertResponseWriterHeader}
• 23d4cd73 - Forward {upload,receive}-pack requests to Gitaly

Compare with previous version

added 1 commit

• cb1e9b5a - Forward {upload,receive}-pack requests to Gitaly

Compare with previous version

assigned to @nick.thomas

assigned to @ahmadsherif

Great @ahmadsherif, just one segment of dead code to remove then I'm happy to merge this

added 1 commit

• 619d33bc - Forward {upload,receive}-pack requests to Gitaly

Compare with previous version

@nick.thomas Please have another look, hopefully the last one :).

unmarked as a Work In Progress

assigned to @nick.thomas

mentioned in issue gitaly#74 (closed)

resolved all discussions

approved this merge request

mentioned in commit c1326899

merged

mentioned in merge request !152 (merged)