Use test helpers in main_test.go

This MR switches us to the assert and require test helpers throughout main_test.go, adding some obviously missing assertions (principally content-types).

Related to #123 (closed)

mentioned in issue #123 (closed)

 1 file changed, 145 insertions(+), 362 deletions(-)

Thanks @nick.thomas . I am still not used to 'testify' yet so I find it instructive to see these examples.

I went over the whole thing. It's a slightly risky change. Some of the logic in these tests takes a few corners, especially when it comes to proxying etc. But I did not see any mistakes. Just one comment about a failure message.

assigned to @nick.thomas

added 1 commit

• c0ca6496 - Use test helpers throughout main_test

Compare with previous version

resolved all discussions

Thanks for the comprehensive review @jacobvosmaer-gitlab !

There is a small amount of risk, but converting the whole file means additions to it are much more likely to use the helpers. Most of the transformations were pretty mechanical.

assigned to @jacobvosmaer-gitlab

approved this merge request

enabled an automatic merge when the pipeline for c0ca6496 succeeds

mentioned in commit 41633621

merged