Suggest better default value for the prometheus port

Fixes: #87 (closed)

assigned to @zj

resolved all discussions

assigned to @nick.thomas

@zj OK, the only remaining question is whether this should bind to the wildcard address by default (:9229) or to localhost (127.0.0.1:9229).

I'm currently of the opinion that it should bind to localhost by default, and I've not heard anything to the contrary.

assigned to @zj

I think the title of this MR is inaccurate. The change looks more like: enable prometheus listener by default. @zj that is what this is doing, isn't it?

@zj what is the status of this MR?

@jacobvosmaer-gitlab Was writing a question this morning, didn't post it, it appears. Anyway:

enable prometheus listener by default.

I agree, I did catch that, and mentioned it in the commit message. I'm not sure if this is the best of ideas, let me know what you want as maintainer.

Regarding https://gitlab.com/gitlab-org/gitlab-workhorse/merge_requests/154#note_27651745, I think its best to go for 127.0.0.1:9229. If you disagree, please let me know.

@zj why should the Prometheus listener be enabled by default? Who are we doing this for? That also has a bearing on the '0.0.0.0 vs 127.0.0.1' question.

In omnibus it's useful to have it on and integrates with the prometheus web app. But for that we don't need to have it on by default. Similarly it is useful in GDK but there we can also have our own defaults.

assigned to @jacobvosmaer-gitlab

added 1 commit

• d8c93c63 - Suggest better default for prometheus port

Compare with previous version

@zj looks good. Could you update the MR description?

assigned to @zj

changed title from Set a default value for the prometheus port to Suggest better default value for the prometheus port

assigned to @jacobvosmaer-gitlab

Thanks @zj!

approved this merge request

mentioned in commit 221b11d7

merged