Skip to content
Snippets Groups Projects

Stop Fail500 and LogError from panicing with nil request or error

Merged Stop Fail500 and LogError from panicing with nil request or error
nick.thomas/gitlab-workhorse:99-robustify-helpers into master
1 unresolved thread
Merged Nick Thomas requested to merge nick.thomas/gitlab-workhorse:99-robustify-helpers into master
1 unresolved thread

Closes #99 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jacob Vosmaer (GitLab) assigned to @nick.thomas

    assigned to @nick.thomas

  • Nick Thomas added 1 commit

    added 1 commit

    • 498f9e2f - Stop Fail500 and LogError from panicing with nil request or error

    Compare with previous version

  • Nick Thomas resolved all discussions

    resolved all discussions

  • Nick Thomas assigned to @jacobvosmaer-gitlab

    assigned to @jacobvosmaer-gitlab

  • Jacob Vosmaer (GitLab) approved this merge request

    approved this merge request

  • Jacob Vosmaer (GitLab) merged

    merged

  • Jacob Vosmaer (GitLab) mentioned in commit c03b113f

    mentioned in commit c03b113f

  • Nick Thomas
    Nick Thomas @nick.thomas ·
    Author Maintainer

    @jacobvosmaer-gitlab should we consider backporting this to v1.3 to help GitLab 8.17 and PCF, per https://gitlab.com/gitlab-org/gitlab-workhorse/issues/99#note_27622263 ?

    /cc @MrChrisW @WarheadsSE

    Edited by Nick Thomas
  • Jason Plum
    Jason Plum @WarheadsSE ·
    Developer

    I can't say it needs to go back that far, because we'll have 9.0 in PCF in the coming week(s) with 9.1 going GA

    • Please register or sign in to reply