Always cancel gRPC stream contexts (!158) · Merge requests · GitLab.org / gitlab-workhorse · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Merged Jacob Vosmaer (GitLab) requested to merge gitaly-cancel-grpc into master 7 years ago

Related to https://gitlab.com/gitlab-org/gitaly/issues/184

It turns out this is necessary with gRPC.

Activity

Jacob Vosmaer (GitLab) assigned to @nick.thomas 7 years ago

assigned to @nick.thomas
Nick Thomas @nick.thomas · 7 years ago

Maintainer

OK, LGTM . Great debugging!
Nick Thomas approved this merge request 7 years ago

approved this merge request
Nick Thomas merged 7 years ago

merged
Nick Thomas mentioned in commit b0b91eb5 7 years ago

mentioned in commit b0b91eb5
Jacob Vosmaer (GitLab) mentioned in issue gitaly#192 (closed) 7 years ago

mentioned in issue gitaly#192 (closed)
Jacob Vosmaer (GitLab) mentioned in issue gitaly#184 (closed) 7 years ago

mentioned in issue gitaly#184 (closed)
Andrew Newdigate added Gitaly label 7 years ago

added Gitaly label
Andrew Newdigate mentioned in issue #128 (closed) 7 years ago

mentioned in issue #128 (closed)
Jacob Vosmaer (GitLab) mentioned in merge request !160 (merged) 7 years ago

mentioned in merge request !160 (merged)

Please register or sign in to reply