Skip to content
Snippets Groups Projects

Use io.Copy in gitaly smarthttp

Merged Jacob Vosmaer (GitLab) requested to merge refactor-smarthttp into master
All threads resolved!

This uses a new helper from gitaly-proto/go/helper. It lets us use more io functions.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nick Thomas
  • Nick Thomas
  • Nick Thomas
  • You could think of https://gitlab.com/gitlab-org/gitlab-workhorse/blob/bc3404336ce30c8bd2001a06bd63d3685dc15eb1/internal/gitaly/smarthttp.go#L124-144 as a similar to io.Copy. This MR replaces that code with an actual call to io.Copy.

  • added 2 commits

    Compare with previous version

  • Nick Thomas resolved all discussions

    resolved all discussions

  • Nick Thomas approved this merge request

    approved this merge request

  • merged

  • Nick Thomas mentioned in commit 3a215f2e

    mentioned in commit 3a215f2e

  • Please register or sign in to reply
    Loading