Do not update/delete: Banner broadcast message test data
Do not update/delete: Notification broadcast message test data
Reassigned to @ayufan
Using variable to pass data between wantModify and modify specified outside of function looks a little suspicious. Can we just merge these two methods?
What is suspicious about it? It is shared state between the two closures. Just like shared state in a struct (method receiver).
req (for sendfile) and path (for errorpage) are also shared state.
req
path
@ayufan if we merge the two methods we end up writing the WriteHeader function again.
Added 1 commit:
On the other hand, splitting a method in two makes it impossible to use nice Go mechanisms like defer. I am liking this solution less now.
Status changed to closed
