Skip to content
Snippets Groups Projects

Allow to access remote archive

Merged Kamil Trzcińśki requested to merge allow-to-access-remote-archive into master
All threads resolved!

This is Workhorse part of https://gitlab.com/gitlab-org/gitlab-ee/issues/2619

Allows extracting individual files from externally stored ZIP archives by using Content-Ranges as described here: https://gitlab.com/gitlab-org/gitlab-ce/issues/29203#note_30198233.

This MR adds vendor for the needed httprs, but also includes changes introduced by patch.

Edited by Jacob Vosmaer (GitLab)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nick Thomas
  • Nick Thomas
  • Thanks @ayufan, a few questions. I'm impressed by how easy it is to support this!

  • assigned to @ayufan

  • Author Maintainer

    I'm too :) It works! :)

  • @ayufan presumably we're not going to merge this until your PR upstream is accepted?

  • Author Maintainer

    @nick.thomas Is accepted already

  • Kamil Trzcińśki removed assignee

    removed assignee

  • I'd rather wait until Nick is happy with this.

  • Nick Thomas
  • Nick Thomas
  • Nick Thomas
  • assigned to @ayufan

  • Thanks @ayufan, a few more comments.

  • Nick Thomas resolved all discussions

    resolved all discussions

  • Nick Thomas resolved all discussions

    resolved all discussions

  • Nick Thomas resolved all discussions

    resolved all discussions

  • Great, onto @jacobvosmaer-gitlab for final review.

  • Looks good!

    I don't know who made @jacobvosmaer approver for this MR. I own that account but I don't use it for work.

  • Jacob Vosmaer (GitLab) changed the description

    changed the description

  • Jacob Vosmaer (GitLab) approved this merge request

    approved this merge request

  • Approvals for everyone!

  • Nick Thomas approved this merge request

    approved this merge request

  • merged

  • mentioned in issue #138 (closed)

  • Please register or sign in to reply
    Loading