pass REMOTE_USER through
Merge request reports
Activity
@nick.thomas Can you please review this?
assigned to @nick.thomas
Thanks @dturner_ts - I can see this being very useful for audit purposes!
We'd need some tests covering the new functionality, to ensure the environment variable is set when appropriate. You should just be able to replicate the
GL_IDtests already present.Edited by Nick Thomasassigned to @dturner_ts
mentioned in merge request gitaly-proto!67 (closed)
@nick.thomas Could you maybe help @dturner_ts finish this MR? This is a really important feature for gitlab-org/gitlab-ce#35287. :)
Edited by Nick ThomasI was waiting on https://gitlab.com/gitlab-org/gitaly-proto/merge_requests/67 to do more work here. Happy to do some more once that's merged. I think the next step after that is gitaly, then this.
Happy to help however I can - just let me know what you need @dturner_ts
@nick.thomas I think approval on https://gitlab.com/gitlab-org/gitaly/merge_requests/299 is the next step.
@dturner_ts I think that this MR and that one can proceed in parallel - both depend on gitaly-proto changes (now merged).
If you pull the updated gitaly-proto into this MR, you should be able to address https://gitlab.com/gitlab-org/gitlab-workhorse/merge_requests/185#note_37610933 by passing the username into the Gitaly messages we create.
@dturner_ts do you mind if I finish this? It doesn't look like the updated gitaly-proto was pulled in correctly?
mentioned in merge request !191 (merged)
@nick.thomas Thanks!
assigned to @nick.thomas
OK, continuing in https://gitlab.com/gitlab-org/gitlab-workhorse/merge_requests/192 . Thanks for your work so far @dturner_ts !
