Migrate Send{Diff,Patch} to Gitaly (!200) · Merge requests · GitLab.org / gitlab-workhorse · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

An error occurred while fetching the assigned milestone of the selected merge_request.

Merged username-removed-506061 requested to merge feature/migrate-send-diff-patch-to-gitaly into master 7 years ago

All threads resolved!

~Conversation: https://gitlab.com/gitlab-org/gitaly/issues/528 and https://gitlab.com/gitlab-org/gitaly/issues/529

Edited 7 years ago by username-removed-506061

Activity

username-removed-506061 marked as a Work In Progress 7 years ago

marked as a Work In Progress
username-removed-506061 unmarked as a Work In Progress 7 years ago

unmarked as a Work In Progress
username-removed-506061 assigned to @jacobvosmaer-gitlab 7 years ago

assigned to @jacobvosmaer-gitlab
Jacob Vosmaer (GitLab) @jacobvosmaer-gitlab started a thread on an old version of the diff 7 years ago

Resolved 7 years ago by Jacob Vosmaer (GitLab)
Last reply by username-removed-506061 7 years ago

Jacob Vosmaer (GitLab) @jacobvosmaer-gitlab · 7 years ago

Contributor

Looks good @ahmadsherif , one question/suggestion about how we pass the request messages.

Jacob Vosmaer (GitLab) assigned to @ahmadsherif 7 years ago

assigned to @ahmadsherif

username-removed-506061 assigned to @jacobvosmaer-gitlab 7 years ago

assigned to @jacobvosmaer-gitlab

Jacob Vosmaer (GitLab) assigned to @ahmadsherif 7 years ago

assigned to @ahmadsherif

username-removed-506061 assigned to @jacobvosmaer-gitlab 7 years ago

assigned to @jacobvosmaer-gitlab

Jacob Vosmaer (GitLab) resolved all discussions 7 years ago

resolved all discussions

Jacob Vosmaer (GitLab) approved this merge request 7 years ago

approved this merge request

Jacob Vosmaer (GitLab) @jacobvosmaer-gitlab · 7 years ago

Contributor

LGTM!

Jacob Vosmaer (GitLab) assigned to @ahmadsherif 7 years ago

assigned to @ahmadsherif

username-removed-506061 assigned to @nick.thomas 7 years ago

assigned to @nick.thomas

Nick Thomas @nick.thomas started a thread on the diff 7 years ago

Resolved 7 years ago by Nick Thomas

Nick Thomas resolved all discussions 7 years ago

resolved all discussions

Nick Thomas @nick.thomas started a thread on an old version of the diff 7 years ago

Resolved 7 years ago by Nick Thomas

Nick Thomas @nick.thomas started a thread on an old version of the diff 7 years ago

Resolved 7 years ago by Nick Thomas

Nick Thomas assigned to @ahmadsherif 7 years ago

assigned to @ahmadsherif

Nick Thomas @nick.thomas started a thread on the diff 7 years ago

Resolved 7 years ago by Nick Thomas

Nick Thomas @nick.thomas started a thread on the diff 7 years ago

Resolved 7 years ago by Nick Thomas

username-removed-506061 assigned to @nick.thomas 7 years ago

assigned to @nick.thomas

Nick Thomas mentioned in issue #148 7 years ago

mentioned in issue #148

Nick Thomas resolved all discussions 7 years ago

resolved all discussions

Nick Thomas @nick.thomas · 7 years ago

Maintainer

OK, LGTM 👍

Nick Thomas approved this merge request 7 years ago

approved this merge request

Nick Thomas merged 7 years ago

merged

Please register or sign in to reply