Sign in and sign out spec helpers causing transient failures
For this screenshot, test should have run with John Doe 5 aka Guest
but it actually run with John Doe 3 aka Master
and therefore he could close the issue. The assertion was not seeing the system note and blue Commands applied widget so test was failing randomly.
Me and @stanhu made an investigation around this screenshot and realised that there are two different versions of gitlab_sign_in
and gitlab_sign_out
in authentication.rb
and login_helpers.rb
. In my case, the test was originally using sign_in
and sign_out
and it was flaky. I changed them to gitlab_sign_in
and gitlab_sign_out
now test works properly and confirmed it running the same test 10+ times.
/cc @stanhu @rspeicher