Unable to rebase unapproved merge request

Overview

Unable to rebase an unapproved merge request in v9.2.7 => v9.3.0 this is a regression caused by https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2031 (don't disable Rebase button for MR without Approvals)

Solution

We throw back a 404 if the merge request is unapproved from the merge_requests_controller - https://gitlab.com/gitlab-org/gitlab-ee/blob/v9.3.1-ee/app/controllers/projects/merge_requests_controller.rb#L343

return render_404 unless @merge_request.approved?

This should be removed and specs added to test these cases.

Links

• https://gitlab.zendesk.com/agent/tickets/79263

@psimyn @fatihacet